-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(messaging): add missing PRIORITY_MIN value it JS part #6033
Conversation
This pull request is being automatically deployed with Vercel (learn more). react-native-firebase-next – ./website_modular🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/2foXBaeHK5kLhWR8MNwpavF9c5LB [Deployment for 16e9c72 canceled] react-native-firebase – ./🔍 Inspect: https://vercel.com/invertase/react-native-firebase/8fhioDBcAnrFq6xfjVgmsxZEe1JS |
Codecov Report
@@ Coverage Diff @@
## main #6033 +/- ##
============================================
- Coverage 53.00% 52.95% -0.04%
+ Complexity 628 623 -5
============================================
Files 208 208
Lines 10195 10195
Branches 1619 1619
============================================
- Hits 5403 5398 -5
- Misses 4541 4542 +1
- Partials 251 255 +4 |
You made a syntax error |
672b9ff
to
16e9c72
Compare
@andersonaddo thanks that notice, Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks right on (based on a check of the related issue, and then looking here) - thanks for noticing this and posting the PR!
@andersonaddo thanks a bunch for the timely assist, I really appreciate it
working up to a release right now, this should be on npmjs.com in a half hour or so after CI runs on main branch post-merge |
Description
messaging.NotificationAndroidPriority.PRIORITY_MIN
wasundefined
Related issues
Fixes #6027
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter