fix(app, android): minSdk should be 19 to match firebase-android-sdk #5984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
As @mikehardy requested in this comment I have tested react-native-firebase on projects with minSdk 19 and it works fine for me.
Release Summary
Downgraded default minSdk from 21 to 19 to support more android devices.
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
It worth mentioning that I'm currently using the cloud messaging package in my project. if anyone is willing to test this PR on the other packages, feel free to clean its project and then apply the same simple change on this PR, and test their packages' functionality, and report the result on this Thread.
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter