Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[📚] Documentation Issue - Enabling MultiDex in RN Firebase #4650

Closed
pebojote opened this issue Dec 5, 2020 · 1 comment
Closed

[📚] Documentation Issue - Enabling MultiDex in RN Firebase #4650

pebojote opened this issue Dec 5, 2020 · 1 comment
Labels
help: good-first-issue Issues that are non-critical issues & well defined for first time contributors.

Comments

@pebojote
Copy link

pebojote commented Dec 5, 2020

Enable MultiDex in React Native Firebase

If you read the Miscellaneous section of RN Firebase Documentation. You may encounter Enabling MultiDex. However, the documentation is not clear when you modify the MainApplication.java. And it says:

rnfb

When you add native libraries like Wix React Native Navigation (https://github.com/wix/react-native-navigation), the MainApplication.java is different:

Annotation 2020-12-05 081135

And you can't just modify this line like this:

public class MainApplication extends MultiDexApplication implements NavigationApplication {

As it will cause an Error. To get around this. I instead use this:

immpor

Solved my problem. 🎉


@pebojote pebojote added help: good-first-issue Issues that are non-critical issues & well defined for first time contributors. Type: Docs labels Dec 5, 2020
@mikehardy
Copy link
Collaborator

Hi there! That's an advanced case, and it is specific to other (not react-native-firebase) libraries that are already extending MainApplication. It is certainly important to document it, but it's on those libraries to do so

At the same time, react-native 0.64 is bumping the minSdkVersion to 21 which means we will finally be able to forget about MultiDex forever when it releases in a week or two

For those two reasons, I don't think this is actionable here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help: good-first-issue Issues that are non-critical issues & well defined for first time contributors.
Projects
None yet
Development

No branches or pull requests

2 participants