Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(messaging/ios): call original delegate when intercepting willPresentNotification #4088

Merged
merged 3 commits into from
Aug 14, 2020

Conversation

ttkien
Copy link
Contributor

@ttkien ttkien commented Aug 14, 2020

Description

  • When app is foreground, the librarie does not call original delegate method which named willPresentNotification
  • The fix follows the approach of commit b17df84 but for method willPresentNotification

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2020

CLA assistant check
All committers have signed the CLA.

@Salakar Salakar changed the title Call original delegate when intercepting willPresentNotification fix: call original delegate when intercepting willPresentNotification Aug 14, 2020
@ttkien ttkien changed the title fix: call original delegate when intercepting willPresentNotification fix(messaging/ios): call original delegate when intercepting willPresentNotification Aug 14, 2020
@mikehardy
Copy link
Collaborator

@ttkien looks like we just need the CLA signed by you and this is good to merge! Thanks!

@ttkien
Copy link
Contributor Author

ttkien commented Aug 14, 2020

@mikehardy Thanks for reminding me. I signed CLA

@mikehardy
Copy link
Collaborator

Great! Looking to release this shortly but it will be my first release on react-native-firebase v6+ which has different processes than v5 had, so give me some time to work out how to drive the release machinery, and this will be live

@mikehardy mikehardy merged commit 62ee961 into invertase:master Aug 14, 2020
hmhm2292 pushed a commit to hmhm2292/react-native-firebase that referenced this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants