fix(ios): handle nil messaging token #3790
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On iOS, calling
[FIRInstanceID instanceID] deleteIDWithHandler
causes a crash. I quite like this method since it enables me to drop all tokens generated until now, and make sure we won't send any more messages to this device (use case: user logout).Related issues
Not reported.
Release Summary
[messaging] Fixed a crash if the fetched token is null (typically when deleting the cloud messaging instance).
Checklist
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
You can try to call
[FIRInstanceID instanceID] deleteIDWithHandler
in your app code (exposing it as a JS API would be welcome by the way!).Thanks a lot for this project!