-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable direct channels API on iOS, fixes #3674 #3733
Merged
Salakar
merged 4 commits into
invertase:master
from
MrLoh:direct-channel-api-deprecated
Jul 14, 2020
Merged
feat: disable direct channels API on iOS, fixes #3674 #3733
Salakar
merged 4 commits into
invertase:master
from
MrLoh:direct-channel-api-deprecated
Jul 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a comment related to shouldEstablishDirectChannel here: react-native-firebase/packages/messaging/ios/RNFBMessaging/RNFBMessaging+FIRMessagingDelegate.m Lines 66 to 68 in 4889c7a
I think it can just be removed, but maybe @Salakar or @Ehesp who have the git blame for this can advice. |
This test will no longer function on simulators as a direct message channel is no longer established.
Salakar
changed the title
Disable direct channels API on iOS, fixes #3674
feat: disable direct channels API on iOS, fixes #3674
Jun 3, 2020
mikehardy
approved these changes
Jul 11, 2020
Salakar
approved these changes
Jul 11, 2020
8 tasks
hmhm2292
pushed a commit
to hmhm2292/react-native-firebase
that referenced
this pull request
Jul 13, 2021
…tase#3733) * set shouldEstablishDirectChannel to NO * tests: make `onMessage` test Android only This test will no longer function on simulators as a direct message channel is no longer established. Co-authored-by: Mike Diarmid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #3674 Direct Channel API on iOS was deprecated, so the SDK shouldn't set
shouldEstablishDirectChannel = YES
anymore. I tested that this doesn't affect the delivery of notifications on iOS.Related issues
Fixes #3674
Release Summary
Remove support for deprecated iOS Direct Channel API (#3674)
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Tested that notifications (including those with data payloads) still arrive on iOS in all 3 states (killed, background, running)