Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't log certain properties with analytics().logBeginCheckout #3681

Closed
5 of 10 tasks
bmamone opened this issue May 23, 2020 · 7 comments
Closed
5 of 10 tasks

Can't log certain properties with analytics().logBeginCheckout #3681

bmamone opened this issue May 23, 2020 · 7 comments
Labels
plugin: analytics Google Analytics for Firebase Type: Stale Issue has become stale - automatically added by Stale bot

Comments

@bmamone
Copy link

bmamone commented May 23, 2020

Issue

If items attribute is present in analytics().logBeginCheckout() the following error is thrown:

[Error: firebase.analytics().logBeginCheckout(*): unknown property 'items'.]

items should be an accepted parameter according to Google, here and here

By checking your docs, I have also found out that coupon parameter should be accepted.


Project Files

Javascript

Click To Expand

package.json:

# N/A

firebase.json for react-native-firebase v6:

# N/A

iOS

Click To Expand

ios/Podfile:

  • I'm not using Pods
  • I'm using Pods and my Podfile looks like:
# N/A

AppDelegate.m:

// N/A


Android

Click To Expand

Have you converted to AndroidX?

  • my application is an AndroidX application?
  • I am using android/gradle.settings jetifier=true for Android compatibility?
  • I am using the NPM package jetifier for react-native compatibility?

android/build.gradle:

// N/A

android/app/build.gradle:

// N/A

android/settings.gradle:

// N/A

MainApplication.java:

// N/A

AndroidManifest.xml:

<!-- N/A -->


Environment

Click To Expand

react-native info output:

 OUTPUT GOES HERE
  • Platform that you're experiencing the issue on:
    • iOS
    • Android
    • iOS but have not tested behavior on Android
    • Android but have not tested behavior on iOS
    • Both
  • react-native-firebase version you're using that has this issue:
    • 7.0.1
  • Firebase module(s) you're using that has the issue:
    • Analytics
  • Are you using TypeScript?
    • No


@bmamone bmamone changed the title Can't log certain properties with logBeginCheckout Can't log certain properties with analytics().logBeginCheckout May 23, 2020
@bmamone bmamone changed the title Can't log certain properties with analytics().logBeginCheckout Can't log certain properties with analytics() May 23, 2020
@bmamone bmamone changed the title Can't log certain properties with analytics() Can't log certain properties with analytics().logBeginCheckout May 23, 2020
@russellwheatley russellwheatley added the plugin: analytics Google Analytics for Firebase label Jun 17, 2020
@russellwheatley
Copy link
Member

Hey @bmamone, we do have a #3385 for analytics that will be updating to the latest analytics API that will be merged in at some point. I'd suggest following that as it has a lot of changes.

@stale
Copy link

stale bot commented Jul 18, 2020

Hello 👋, to help manage issues we automatically close stale issues.
This issue has been automatically marked as stale because it has not had activity for quite some time. Has this issue been fixed, or does it still require the community's attention?

This issue will be closed in 15 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the Type: Stale Issue has become stale - automatically added by Stale bot label Jul 18, 2020
@stale
Copy link

stale bot commented Aug 2, 2020

Closing this issue after a prolonged period of inactivity. If this is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Aug 2, 2020
@DanGDroid
Copy link

this still reproduced on "@react-native-firebase/analytics": "^11.3.3",
all events that include items in params fail with the error example:
Analytics failed sendPredefinedFirebaseEvent` Error: firebase.analytics().logAddPaymentInfo(*): unknown property 'items'.

@mikehardy
Copy link
Collaborator

@habeebtheprogrammer
Copy link

same issue.

@mikehardy
Copy link
Collaborator

@habeebtheprogrammer please open a new issue if you have a reproduction. This one is closed
https://stackoverflow.com/help/how-to-ask
https://stackoverflow.com/help/minimal-reproducible-example
https://github.com/mikehardy/rnfbdemo/blob/main/make-demo.sh + an App.js that reproduces when dropped in result of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: analytics Google Analytics for Firebase Type: Stale Issue has become stale - automatically added by Stale bot
Projects
None yet
Development

No branches or pull requests

6 participants
@mikehardy @bmamone @DanGDroid @russellwheatley @habeebtheprogrammer and others