Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal][WIP] Storage improvements #1260

Closed
5 tasks
Salakar opened this issue Jul 1, 2018 · 7 comments
Closed
5 tasks

[Proposal][WIP] Storage improvements #1260

Salakar opened this issue Jul 1, 2018 · 7 comments
Assignees
Labels
help: general General help wanted help: needs-triage Issue needs additional investigation/triaging. platform: android platform: ios platform: javascript plugin: storage Firebase Cloud Storage type: bug New bug report Workflow: Waiting for User Response Blocked waiting for user response.
Milestone

Comments

@Salakar
Copy link
Contributor

Salakar commented Jul 1, 2018

Hi all 👋

storage() has fallen slightly behind recently and we plan on improving the module for a 5.x.x release which includes improving it to ensure that it provides the all the functionality in an easy to use and reliable manner with better documentation and bug fixes.

This issue is a placeholder that will be updated as we have more details on what will be supported and how this will be structured in the API.

Secondly, it's also here to show that we're aware of the issues that have already been raised and will be addressing them as part of this proposal. Any historic or new issues will be closed and redirected here to track all the issues that need addressing in one place.

New features to add:

  • Multi-bucket support
    • RNFB internals re-written to support this JS side in 7632da1 - just needs storage work done now.
  • StorageTask; and support for resumable uploads/downloads
    • cancel()
    • resume()
    • pause()

Loving react-native-firebase and the support we provide? Please consider supporting us with any of the below:

@Salakar
Copy link
Contributor Author

Salakar commented Jul 10, 2018

The issues linked above (except multiple bucket support) have live fixes now in the v4.3.0 release.

New features / adding support for missing features will be done in the v5.x.x release cycle.


Loving react-native-firebase and the support we provide? Please consider supporting us with any of the below:

@Salakar Salakar added this to the v5.0.0 Release milestone Jul 21, 2018
@Salakar
Copy link
Contributor Author

Salakar commented Aug 13, 2018

image

@Salakar Salakar modified the milestones: v5.0.0 Release, v5.1.0 Sep 24, 2018
@Salakar Salakar modified the milestones: v5.1.0, v5.2.0 Oct 27, 2018
@ziyafenn
Copy link

Guys, multiple storage support has not yet been released?
Thanks.

@Salakar Salakar modified the milestones: v5.2.0, v6.0.0 Nov 25, 2018
@mtford90
Copy link

@ziyafenn doesn't appear so. I've had to add multiple app instances - one for each bucket.

@Salakar
Copy link
Contributor Author

Salakar commented Jan 21, 2019

@mtford90 @ziyafenn these things take time sorry, but I can with 100% certainty say that this will be in v6.0.0 given that it's a full rework to bring 100% Firebase SDK surface coverage in 21 modules.

You can track it here; #1837

No small release as you can see. 🙈

@Salakar Salakar closed this as completed Apr 9, 2019
@Salakar Salakar reopened this Apr 9, 2019
@Salakar
Copy link
Contributor Author

Salakar commented Apr 10, 2019

@mtford90 @ziyafenn #2043 PR is up and in progress now; check the changelog linked there; this has multi-bucket support already implemented.

Will ping when a v6.0.0 is out with Storage ready.

@Salakar
Copy link
Contributor Author

Salakar commented Apr 13, 2019

Closing in favour of the above-mentioned PR.

@Salakar Salakar closed this as completed Apr 13, 2019
@mikehardy mikehardy removed the Workflow: Needs Review Pending feedback or review from a maintainer. label Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help: general General help wanted help: needs-triage Issue needs additional investigation/triaging. platform: android platform: ios platform: javascript plugin: storage Firebase Cloud Storage type: bug New bug report Workflow: Waiting for User Response Blocked waiting for user response.
Projects
None yet
Development

No branches or pull requests

4 participants