Typings for PhoneAuthListener is not right

[sowdri]

Issue

The typings for PhoneAuthListener is not right.

interface PhoneAuthListener {
      on(
        event: string,
        observer: () => PhoneAuthSnapshot,
        errorCb?: () => PhoneAuthError,
        successCb?: () => PhoneAuthSnapshot
      ): PhoneAuthListener;

      then(fn: () => PhoneAuthSnapshot): Promise<any>;

      catch(fn: () => Error): Promise<any>;
    }

The function signature of observer, then and catch should have been the following:

interface PhoneAuthListener {
      on(
        event: string,
        observer: (snapshot: PhoneAuthSnapshot) => void,
        errorCb?: (error: PhoneAuthError) => void ,
        successCb?: (snapshot: PhoneAuthSnapshot) => void
      ): PhoneAuthListener;

      then(fn: (snapshot: PhoneAuthSnapshot) => void): Promise<any>;

      catch(fn: (error: Error) => void): Promise<any>;
    }

Environment

1. Application Target Platform: Both

2. Development Operating System: NA

3. Build Tools: NA

4. React Native version: NA

5. RNFirebase Version: 4.2.0

6. Firebase Module: Auth

[chrisbianca]

Merged #1185 to address this. Thanks for flagging.