Some option to bypass the remapping of localhost

[stchristian]

I came accross a problem with emulators and the way they are handling localhost addresses, described here.

It's nice that now remapping is logged out, but it would be nicer to bypass this feature with some flag, so I don't have to always reconfigure Host IP when I am connecting to another network.
I would love to see this work with firebase emulators, when running and testing apps on real devices.

[mikehardy]

Hi there! I'd be open to a PR that implemented that somehow. Perhaps a firebase.json key?

It's possible in javascript to get the full contents of the firebase.json, so fetching the JSON then that key (if available) may be used as a conditional in the remapping code?

Something like this I think ?

https://github.com/invertase/react-native-firebase/blob/master/packages/app/e2e/config.e2e.js#L28-L35

[stchristian]

Yes, a key in the firebase.json would be great. Is there any example when this config is used in JS?
I'd be happy to open a PR in the future

[stchristian]

I am on this issue, but need a little help.
I did the following in function, auth, firestore modules:

    const androidBypassEmulatorUrlRemap =
      typeof this.firebaseJson.android_bypass_emulator_url_remap === 'boolean' &&
      this.firebaseJson.android_bypass_emulator_url_remap;
    if (!androidBypassEmulatorUrlRemap && isAndroid && _origin) {

I tried to run tests (yarn tests:jest) but it throws error when the above mentioned getter runs, it says it couldn't parse the json file. I logged out the arguments that it got and its undefined... I guess I need to somehow initalize a native module but don't really know how?!

UPDATE:
Okay, found out that I could provide a firebase.json mock in jest.setup.ts for the JS only tests. However it would be nice to somehow test this behaviour...

[mikehardy]

I see your update - yes you'll have to mock it, for an on device test add it to the e2e javascript tests you see in the packages and then run that harness - it's not as dire as it sounds, especially since it's android-only for the test and you can use a .only while writing the test in combo with yarn tests:android:test-reuse to really quickly iterate - https://github.com/invertase/react-native-firebase/blob/master/tests/README.md has all the instructions

[mikehardy]

a new test after this one for instance might serve ?

react-native-firebase/packages/app/e2e/config.e2e.js

Lines 28 to 34 in 514e6bd

	describe('json', function () {
	it('should read firebase.json data', async function () {
	const jsonData = await NativeModules.RNFBAppModule.jsonGetAll();
	jsonData.rnfirebase_json_testing_string.should.equal('abc');
	jsonData.rnfirebase_json_testing_boolean_false.should.equal(false);
	jsonData.rnfirebase_json_testing_boolean_true.should.equal(true);
	});

[stchristian]

Finally I've got to run the tests. It was a nice experience, however I don't think I should add tests for this flag.
I guess I'll just simply extend the documentation

[mikehardy]

ok

[stchristian]

Hi again!

I got the code working with the patches, but it took a lot of time to figure out that the android_bypass_emulator_url_remap should be under a react-native key in the firebase.json in order for the flag to work.

Is this the expected behaviour?
If so the documentation should really say something about that

[mikehardy]

A reasonable point, just added this 1162475
It'll publish on the page you linked as soon as Vercel finishes chewing on it and deploys, some 5-10mins