Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] fix infinite loop if classic frontend is disabled #8614

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

matmair
Copy link
Member

@matmair matmair commented Dec 2, 2024

Fixes #8575

@matmair matmair added bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface labels Dec 2, 2024
@matmair matmair added this to the 1.0.0 milestone Dec 2, 2024
@matmair matmair self-assigned this Dec 2, 2024
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 01abf4f
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/674d0421e547960008876e03
😎 Deploy Preview https://deploy-preview-8614--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.60%. Comparing base (8ac8527) to head (01abf4f).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/backend/InvenTree/plugin/plugin.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8614   +/-   ##
=======================================
  Coverage   84.60%   84.60%           
=======================================
  Files        1188     1188           
  Lines       54270    54269    -1     
  Branches     2050     2050           
=======================================
  Hits        45915    45915           
+ Misses       7848     7847    -1     
  Partials      507      507           
Flag Coverage Δ
backend 86.05% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matmair
Copy link
Member Author

matmair commented Dec 2, 2024

@SchrodingersGat this seems to work; But could you verify before merge? This seems to easy

@matmair matmair marked this pull request as ready for review December 2, 2024 06:54
@SchrodingersGat
Copy link
Member

@matmair yup, seems to have fixed the issue, nice work :)

@SchrodingersGat SchrodingersGat merged commit 4f3e8cb into inventree:master Dec 2, 2024
28 checks passed
@SchrodingersGat SchrodingersGat deleted the matmair/issue8575 branch December 2, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PUI] infinite loop if classic frontend is disabled
2 participants