Custom states does not work as expected

[gunstr]

Please verify that this bug has NOT been raised before.

• I checked and didn't find a similar issue

Describe the bug*

I have created some custom states with OK as Logical State.

If I start with a part that have OK as state:

and changed that to Lab Item for example the state is changed but the stock is indicated as Not Available

If I open the stock item in the admin interface I can see the custom status key entry is blank.

If I enter the custom state value (102 in this case) in the field and go back to the stock list the part is available again and it all looks OK.

It's strange that the Custom State is rendered correctly even if the custom status key is blank but I guess there are more fields involved that I'm not aware of. The manual edititing I did in the admin interface might be completely wrong, but it seems to work...

Steps to Reproduce

Se above

Tried to reproduce on the Demo site but the database seems to be corrupted

Expected behaviour

A Custom State linked to the OK status should be considered as available

Deployment Method

• Docker
• Package
• Bare metal
• Other - added info in Steps to Reproduce

Version Information

Please verify if you can reproduce this bug on the demo site.

• I can reproduce this bug on the demo site.

Relevant log output

[gunstr]

Just found out that this happens when changing state directly from the stock item list (it was discovered when I did a bulk change). If I open each stock item individually and change state from the "edit" modal the Custom status key is updated as it should.

[matmair]

I will look into this, I don’t think we have tests that cover this scenario.

[SchrodingersGat]

@gunstr so it is the "bulk change status" operation which is at fault here?

[gunstr]

Not really, the same happens also if just one stock item is selected from the table.

[matmair]

That is actually the same endpoint, I think I have found the issue. A PR should follow in the next days.

[matmair]

@gunstr trying to reproduce this and running into issues triggering the behaviour: can you confirm that it is happening on current 'master' on the page /stock/location/index/stock-items . I am trying with a freshly set up demo dataset

[gunstr]

Hmmm, I tried on the Demo site right now but I can't get the custom state populated in the drop down at all now...

I added a Custome State with the name Test State 1 in the admin center

Then I click the very first part in the parts list and from there I select the Stock tab to the left, selects both stock items and then the Change stock status action

In the Modal that opens I can not see the Test State 1 status at all in the Status drop down - do you see anyting I'm doing wrong here?