Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] fontawesome Quality of Live improvements #6064

Closed
1 of 2 tasks
philipp2310 opened this issue Dec 10, 2023 · 5 comments
Closed
1 of 2 tasks

[FR] fontawesome Quality of Live improvements #6064

philipp2310 opened this issue Dec 10, 2023 · 5 comments
Labels
inactive Indicates lack of activity old user interface Issues with Old User interface

Comments

@philipp2310
Copy link

philipp2310 commented Dec 10, 2023

Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find a similar feature request

Problem statement

At the moment you have to type the full icon name and save it to see if you did a mistake

Suggested solution

  1. Show a preview of the currently entered icon next to the input field
  2. Allow pasting of the font awesome website -> regex from<i class="fas fa-store"></i> to fas fa-store

Describe alternatives you've considered

Of course it would be awesome if there was even suggestions while you type, but that is another level of complexity

Examples of other systems

I used roughly the following code for this in another project on input:

icon(input) {
  // fallback if empty
  if (input === '' || input === undefined)
    return 'fas fa-box' 
  const regex = /<i class="(.*)"><\/i>/
  const matches = regex.exec(input)
  if (matches) {
    return matches[1]
  }
  // if it is not copied - keep input
  return input
}

Do you want to develop this?

  • I want to develop this.
@philipp2310 philipp2310 added enhancement This is an suggested enhancement or new feature triage:not-checked Item was not checked by the core team labels Dec 10, 2023
@wolflu05
Copy link
Contributor

This would be an easy addition, but in long term, I would like to have something like explained here. And as we are currently already rewriting the frontend to use react, I think this wouldn't be to hard to develop, but it was not my priority.

@SchrodingersGat
Copy link
Member

@philipp2310 as we are currently pushing to move the entire frontend to react then this will not receive attention from the core devs. If you want to implement this yourself and push a PR, I'd look at it, but better would be to look at how this could be implemented in the new interface :)

@SchrodingersGat SchrodingersGat added old user interface Issues with Old User interface and removed enhancement This is an suggested enhancement or new feature triage:not-checked Item was not checked by the core team labels Dec 10, 2023
@wolflu05
Copy link
Contributor

I just realized, I forgot to add the link I was referring to in my last post. But here it is: #5354 (comment)

Basically what I thought would be good is a button where you can click on and then an popup opens where you can select and search for you icon and set it via a click. That would be good, so that we also have some kind of standard set of icons around every platform (pui, cui, mobile app and the python script)

Copy link
Contributor

This issue seems stale. Please react to show this is still important.

@github-actions github-actions bot added the inactive Indicates lack of activity label Feb 11, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 19, 2024
@matmair
Copy link
Member

matmair commented Feb 19, 2024

I think this will be addressed by @LavissaWoW . Although we are switching away from Fontawesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Indicates lack of activity old user interface Issues with Old User interface
Projects
None yet
Development

No branches or pull requests

4 participants