Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR/P-UI] Release: Package #5278

Closed
3 tasks done
Tracked by #5212
matmair opened this issue Jul 18, 2023 · 7 comments
Closed
3 tasks done
Tracked by #5212

[FR/P-UI] Release: Package #5278

matmair opened this issue Jul 18, 2023 · 7 comments
Assignees
Labels
CI CI / unit testing ecosystem setup Relates to the InvenTree setup / installation process
Milestone

Comments

@matmair
Copy link
Member

matmair commented Jul 18, 2023

Build Platform UI during package creation and include with release.

Tasks

@matmair matmair changed the title Release: Package [FR/P-UI] Release: Package Jul 18, 2023
@matmair matmair self-assigned this Jul 18, 2023
@matmair matmair added CI CI / unit testing ecosystem setup Relates to the InvenTree setup / installation process labels Jul 18, 2023
@matmair matmair modified the milestones: 1.0.0, 0.13.0 Jul 18, 2023
@SchrodingersGat SchrodingersGat modified the milestones: 0.13.0, horizon Oct 17, 2023
@matmair matmair modified the milestones: horizon, 0.16.0 Jul 7, 2024
@matmair
Copy link
Member Author

matmair commented Jul 14, 2024

I would like to remove the possibility that users need to manually download the frontend bundle from GitHub - it is presenting problems with #7338.

I have 2 ideas for that:

  1. provide a proxy service that gets and caches frontend archives
  2. push new frontend archives to GitHub external storage like a s3 bucket

Both are trivial to build but add a bit of infrastructure. I would be willing to build and standup either solution. Thoughts @SchrodingersGat @wolflu05?

@SchrodingersGat
Copy link
Member

@matmair can you explain why #7338 is happening and what either 1) or 2) is solving?

@matmair
Copy link
Member Author

matmair commented Jul 14, 2024

#7338 is a mixture of 2 things: the script assumes that git is present (which isn’t required on package installations) and than would have to get the frontend package from GitHub. The second part is an issue because you need to manually download the frontend package from GitHub Artifacts for non-tagged commits - see

GitHub doesn't allow artifact downloads from anonymous users. Either download the following file

All non-tagged versions need to manually get the frontend on bare metal or package installer methods. This was fine with PUI being in dev but it being the main UI this will break deployments.
So we need a way to get the frontend without manual intervention. This can be done by either 1 or 2.

@wolflu05
Copy link
Contributor

I would be fine with both options, but if we choose the first, we need to know that gh artifacts are deleted after 90 days, which means that we could only provide builds for the users for the last 90 days. If they want to use an older version, they need to build them their self (is currently already the case).

@matmair
Copy link
Member Author

matmair commented Jul 15, 2024

I have created a PR that shows where the current way is limited: #7655
Important info: The package build context does not have a way to pass tokens in - so it can only use publicly available resources during the build process

@matmair
Copy link
Member Author

matmair commented Aug 9, 2024

This will have to be pushed back. I have privately tested 2 but it will take to long too get this into 0.16.0

@matmair
Copy link
Member Author

matmair commented Nov 12, 2024

This works for release builds, maybe in the future there could be a warning if a build does not include PUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI / unit testing ecosystem setup Relates to the InvenTree setup / installation process
Projects
Status: Done
Development

No branches or pull requests

3 participants