-
-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR/P-UI] Release: Package #5278
Comments
I would like to remove the possibility that users need to manually download the frontend bundle from GitHub - it is presenting problems with #7338. I have 2 ideas for that:
Both are trivial to build but add a bit of infrastructure. I would be willing to build and standup either solution. Thoughts @SchrodingersGat @wolflu05? |
#7338 is a mixture of 2 things: the script assumes that git is present (which isn’t required on package installations) and than would have to get the frontend package from GitHub. The second part is an issue because you need to manually download the frontend package from GitHub Artifacts for non-tagged commits - see Line 1345 in 76f8a2e
All non-tagged versions need to manually get the frontend on bare metal or package installer methods. This was fine with PUI being in dev but it being the main UI this will break deployments. |
I would be fine with both options, but if we choose the first, we need to know that gh artifacts are deleted after 90 days, which means that we could only provide builds for the users for the last 90 days. If they want to use an older version, they need to build them their self (is currently already the case). |
I have created a PR that shows where the current way is limited: #7655 |
This will have to be pushed back. I have privately tested 2 but it will take to long too get this into 0.16.0 |
This works for release builds, maybe in the future there could be a warning if a build does not include PUI. |
Build Platform UI during package creation and include with release.
Tasks
The text was updated successfully, but these errors were encountered: