Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests: fix comment notifications #417

Closed
slint opened this issue Dec 3, 2024 · 0 comments · Fixed by inveniosoftware/invenio-app-rdm#2930, #418 or inveniosoftware/invenio-communities#1256

Comments

@slint
Copy link
Member

slint commented Dec 3, 2024

Comments in requests that have communities as recipients (because they're referenced in the created_by or receiver fields), like e.g. member invitations or subcommunity requests, are not triggering notifications to any recipients.

The only way this somehow worked in the past was because a user commented on the request and afterwards they're part of the "user participants" in the timeline that can then be targeted as recipients.

@slint slint converted this from a draft issue Dec 3, 2024
@carlinmack carlinmack moved this from In progress to In review 🔎 in Sprint Q1/2025 Dec 3, 2024
@carlinmack carlinmack removed their assignment Dec 3, 2024
@slint slint closed this as completed in #418 Dec 9, 2024
@github-project-automation github-project-automation bot moved this from In review 🔎 to To release 🤖 in Sprint Q1/2025 Dec 9, 2024
@slint slint moved this from To release 🤖 to In review 🔎 in Sprint Q1/2025 Dec 9, 2024
@slint slint reopened this Dec 9, 2024
@github-project-automation github-project-automation bot moved this from In review 🔎 to To release 🤖 in Sprint Q1/2025 Dec 9, 2024
@slint slint moved this from To release 🤖 to Released ✔️ in Sprint Q1/2025 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released ✔️
2 participants