-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize new custom fields #1231
Serialize new custom fields #1231
Comments
We have two options in the RFC:
class RandomFieldExporter:
def marc_xml():
...
def datacitev43():
...
RDM_CUSTOM_FIELDS = {
"experiment": VocabularyCF(
...
export=RandomFieldExporter()
),
}
class MARCXmlExporter:
def experiments():
...
class DublinCoreExporter:
def experiments():
...
RDM_CUSTOM_FIELDS = {
"experiment": VocabularyCF(
...
export=dict(
marc=MARCXmlExporter(),
dublin_core=DublinCoreExporter()
)
),
} This topic needs a discussion before the implementation |
We decided to prototype the option The prototype should also contain multiple formats to have a grasp on how this can grow in terms of code |
For the prototype, we decided to add a generic post dump pipeline (can also be implemented for other stages of the serialization, e.g. Each serializer then adds the steps it sees fit for its own needs (e.g. |
To showcase the implemented mechanism I implemented Since this will scale up (e.g. X formats * Y custom fields), I will first wait until the post_dump/pre_dump mechanism is fully approved before implementing all the combinations of custom fields and formats. Thus, I am moving the issue to review |
Support new custom fields: journal, thesis, notes, meeting, imprint in existing serializers:
The text was updated successfully, but these errors were encountered: