Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: investigate github app import #107

Closed
alejandromumo opened this issue Jul 3, 2023 · 0 comments · Fixed by #109
Closed

config: investigate github app import #107

alejandromumo opened this issue Jul 3, 2023 · 0 comments · Fixed by #109
Assignees

Comments

@alejandromumo
Copy link
Member

          question: importing the `REMOTE_APP` could be troublesome if it was replaced by another instance. Perhaps we should get the github remote app using the oauth-client extension.

E.g:

remote = LocalProxy(
        lambda: current_oauthclient.oauth.remote_apps[
            current_app.config["GITHUB_WEBHOOK_RECEIVER_ID"]
        ]
    )

However this is config, can we lazy load?

Originally posted by @alejandromumo in #99 (comment)

@slint slint assigned slint and alejandromumo and unassigned slint Jul 5, 2023
@alejandromumo alejandromumo removed their assignment Jul 10, 2023
@zzacharo zzacharo self-assigned this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants