Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

talisman upgrade #78

Open
nkenobi opened this issue May 2, 2021 · 1 comment
Open

talisman upgrade #78

nkenobi opened this issue May 2, 2021 · 1 comment
Labels

Comments

@nkenobi
Copy link

nkenobi commented May 2, 2021

Package version (if known): latest

Describe the bug

The dependency on very old talisman <0.5.1 is a blocker

Steps to Reproduce

  1. I am consistently (every time) encountering the issue with AttributeError (due to race condition). It crashes the server with uwsgi/gunicorn
  2. They have fixed and upgraded to 0.5.1 - it is now at 0.7
    AttributeError: frame_options GoogleCloudPlatform/flask-talisman#22

Expected behavior

It is to be upgraded to latest

Screenshots (if applicable)

Additional context

Also saw the related issue in inveniosoftware/invenio-admin#66
But the upgrade in this core package should not be held up as the downstream app fails without it.

Further, I've locally upgraded to 0.7 and it fixes the AttributeError problem.

@nkenobi nkenobi added the bug label May 2, 2021
@nkenobi
Copy link
Author

nkenobi commented May 23, 2021

Any ETA on fixing this major bug ?
Its 3 years since it was fixed by talisman.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant