Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parent-doi: add link to record landing page #2314

Merged

Conversation

zzacharo
Copy link
Member

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

word-wrap: break-word;
}
}
.ui.divided.list {
Copy link
Contributor

@kpsherva kpsherva Jul 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed?

@@ -54,6 +54,18 @@
word-wrap: break-word;
font-size: 80%;
}

&.parent-doi:last-child {
padding-right: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-0 class can be used directly instead

Comment on lines +63 to +64
margin-top: .5rem;
word-wrap: break-word;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these already exist for class .doi, see list.overrides line 50, could be reused?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it but display: block and font-size is not what we want for the parent doi....

@zzacharo zzacharo force-pushed the add-parent-doi-landing-page branch 2 times, most recently from b265e7e to 43cad45 Compare July 21, 2023 07:24
<p>How does DOI versioning work?</p>
</h5>
<p>
When you publish an upload on Zenodo for the first time, we register two
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When you publish an upload on Zenodo for the first time, we register two
When you publish an upload for the first time, we register two

<p>Afterwards, we register a DOI for every new version of your upload.</p>
<p>
This is best illustrated by an example of a software package. If the
software has been released in two versions (v1.0 and v1.1) on Zenodo, then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
software has been released in two versions (v1.0 and v1.1) on Zenodo, then
software has been released in two versions (v1.0 and v1.1), then

the following DOIs would have been registered:
</p>
<ul>
<li><strong>v1.0 (specific version):</strong> 10.5281/zenodo.60943</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li><strong>v1.0 (specific version):</strong> 10.5281/zenodo.60943</li>
<li><strong>v1.0 (specific version):</strong> 10.1234/7s0da-05p39</li>

</p>
<ul>
<li><strong>v1.0 (specific version):</strong> 10.5281/zenodo.60943</li>
<li><strong>v1.1 (specific version):</strong> 10.5281/zenodo.800648</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li><strong>v1.1 (specific version):</strong> 10.5281/zenodo.800648</li>
<li><strong>v1.1 (specific version):</strong> 10.1234/chc5z-w0r30</li>

<ul>
<li><strong>v1.0 (specific version):</strong> 10.5281/zenodo.60943</li>
<li><strong>v1.1 (specific version):</strong> 10.5281/zenodo.800648</li>
<li><strong>Concept (all versions):</strong> 10.5281/zenodo.705645</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li><strong>Concept (all versions):</strong> 10.5281/zenodo.705645</li>
<li><strong>Concept (all versions):</strong> 10.1234/3s67k-pd636</li>

resource.
</p>
<p>
See also <a href="https://doi.org/10.5438/55E5-T5C0">Cool DOIs</a> blog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See also <a href="https://doi.org/10.5438/55E5-T5C0">Cool DOIs</a> blog
See also <a href="https://doi.org/10.5438/55E5-T5C0">Cool DOIs</a> for further information.

</p>
<p>
See also <a href="https://doi.org/10.5438/55E5-T5C0">Cool DOIs</a> blog
post by Martin Fenner, DataCite Technical Director.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
post by Martin Fenner, DataCite Technical Director.

</p>

<h5>
<p>Why do you include “zenodo” in the DOI?</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this question

</h5>
<p>
No, if you change a 10kb README file in 50GB dataset we do not duplicate
the entire 50GB dataset. Invenio v3, the underlying digital repository
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the entire 50GB dataset. Invenio v3, the underlying digital repository
the entire 50GB dataset. InvenioRDM, the underlying technical software platform,

<p>
No, if you change a 10kb README file in 50GB dataset we do not duplicate
the entire 50GB dataset. Invenio v3, the underlying digital repository
platform that powers Zenodo, efficiently handles the file storage so we
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
platform that powers Zenodo, efficiently handles the file storage so we
efficiently handles the file storage so we

@zzacharo zzacharo force-pushed the add-parent-doi-landing-page branch from 43cad45 to 79ab8b8 Compare July 21, 2023 08:21
@zzacharo zzacharo force-pushed the add-parent-doi-landing-page branch from 79ab8b8 to dd78d50 Compare July 21, 2023 15:26
@zzacharo zzacharo merged commit 13181d4 into inveniosoftware:master Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants