-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename function dim
-> dims
#10
Comments
The main use of the |
it's a fair point - lets leave this open to see if anyone else has an opinion, and otherwise keep as is? |
when #21 is merged this can likely be closed as the version of the function that returns Though the version that accepts tuples |
I'm happy enough for this to stay as |
I know this is a bike-shed-y naming issue, but...
I think
dims
would be really nice, to go withndims
,permutedims
,dropdims
, etc.We might have to do something ugly in the source code, like write
NamedDims.dims
all over or define an alias likeconst _dims = dims
, but it might be worth doing if it's a nicer API for the user.The text was updated successfully, but these errors were encountered: