Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect -> Matrix #29

Merged
merged 3 commits into from
Aug 25, 2021
Merged

collect -> Matrix #29

merged 3 commits into from
Aug 25, 2021

Conversation

willtebbutt
Copy link
Member

Make things fast. @thomasgudjonwright could you run on your example and confirm that it goes from around 40s to 4s?

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #29 (d51107b) into master (8e5f9f4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          158       158           
=========================================
  Hits           158       158           
Impacted Files Coverage Δ
src/ilmm.jl 100.00% <100.00%> (ø)
src/independent_mogp.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdc4cf7...d51107b. Read the comment docs.

Copy link
Member

@thomasgudjonwright thomasgudjonwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed it does accelerate the computation, thanks!

@willtebbutt willtebbutt merged commit d005a76 into master Aug 25, 2021
@willtebbutt willtebbutt deleted the wct/make-indep-mogp-fast branch August 25, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants