Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glimmer? #31

Open
nanuxbe opened this issue May 14, 2015 · 0 comments
Open

Glimmer? #31

nanuxbe opened this issue May 14, 2015 · 0 comments

Comments

@nanuxbe
Copy link

nanuxbe commented May 14, 2015

Hi,

great work on creating this addon.

I've tried ember-table with glimmer (and liquid-fire 0.20.0) and it doesn't work yet.
I've identified 1 problem in 2 places I was able to fix: onScrollLeftDidChange gets called in header-row.js and scroll-container.js while nothing has be rendered yet, which leads to an execption. Testing if this.$() !== undefined before calling .scrollLeft on it works.

Once this is fixed, the table renders but it's empty, I would guess this has to do with the lazy-rendering of the table content that would probably interfere with glimmer's new virtual-dom?

I was wondering if you had plans to fix this here or if you were waiting for addepar to fix it upstream (or had no plan at all to support glimmer)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant