Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectInspector: Add Name #15

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

tylerkrupicka
Copy link
Contributor

@tylerkrupicka tylerkrupicka commented Feb 23, 2021

What Changed

Closes #14

Added a name prop to ObjectInspector to support named root values, similar to how Storybook currently names the object root. In the process I also fixed the color of the colon after a key in the object label.

Why

What might be impacted

Todo:

  • Add tests
  • Add docs
📦 Published PR as canary version: 1.0.4-canary.15.363.0

✨ Test out this PR locally via:

npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
# or 
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]

@tylerkrupicka tylerkrupicka added the minor Minor version change label Feb 23, 2021
@tylerkrupicka
Copy link
Contributor Author

tylerkrupicka commented Feb 23, 2021

Bundle Size Report

name master pr +/- %
@devtools-ds/themes 6.01 kB 6.07 kB 59.00 Bytes 0.98%
@devtools-ds/object-inspector 23.92 kB 24.26 kB 343.00 Bytes 1%
Total 29.93 kB 30.33 kB 402.00 Bytes 1%

✅ No size breaking changes detected

Courtesy of your bundle-size bot 📦🚀

@tylerkrupicka tylerkrupicka force-pushed the named-object-inspector branch from 75893e2 to d81e139 Compare March 14, 2021 23:18
@tylerkrupicka
Copy link
Contributor Author

Build Info

Your PR was successfully deployed by CircleCI #364

Storybook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Minor version change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'Name' Property to ObjectInspector
1 participant