Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade date-math #1354

Merged
merged 1 commit into from
Jun 10, 2019
Merged

chore(deps): upgrade date-math #1354

merged 1 commit into from
Jun 10, 2019

Conversation

TrySound
Copy link
Collaborator

The diff is quite nice.

-    "minified": 150810,
+    "minified": 148190,
-    "gzipped": 45487
+    "gzipped": 44792

The diff is quite nice.

```diff
-    "minified": 150810,
+    "minified": 148190,
-    "gzipped": 45487
+    "gzipped": 44792
```
inRange,
min,
max,
} from 'date-arithmetic'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both imports?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. This one is only reexport.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rollup warned about duplicated diff (date-arithmetic has own) and after expansion warned about unused external imports.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jquense jquense changed the title Upgrade date-math chore(deps): upgrade date-math Jun 10, 2019
@jquense jquense merged commit 762e8cf into jquense:master Jun 10, 2019
@TrySound TrySound deleted the upgrade_date_arithmetic branch June 10, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants