Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loanstats cron job crashing #4497

Closed
cclauss opened this issue Jan 28, 2021 · 0 comments · Fixed by internetarchive/infogami#134
Closed

Loanstats cron job crashing #4497

cclauss opened this issue Jan 28, 2021 · 0 comments · Fixed by internetarchive/infogami#134
Assignees
@cclauss
Labels
Lead: @cclauss Issues overseen by Chris (Python3 & Dev-ops lead 2019-2021) [managed] Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed]
Milestone
Sprint 2021-01

Comments

@cclauss
Copy link
Contributor

cclauss commented Jan 28, 2021 •
edited
Loading

Fixed in internetarchive/infogami#134
Subtask of #4383
Python 2: /openlibrary/core/loanstats.py", line 10, in from urllib.parse import urlencode
Python 3: if _is_illegal_header_value(values[i]): TypeError: expected string or bytes-like object

Evidence / Screenshot (if possible)

Relevant url?

Steps to Reproduce

  1. Go to ...
  2. Do ...
  • Actual:
  • Expected:

Details

  • Logged in (Y/N)?
  • Browser type/version?
  • Operating system?
  • Environment (prod/dev/local)? prod

Proposal & Constraints

Related files

Stakeholders
@cclauss cclauss added Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Jan 28, 2021
@cclauss cclauss changed the title Loanstats crashing Loanstats cron job crashing Jan 29, 2021
@cclauss cclauss added the Lead: @cclauss Issues overseen by Chris (Python3 & Dev-ops lead 2019-2021) [managed] label Jan 29, 2021
@cclauss cclauss added this to the Active Sprint milestone Jan 29, 2021
@cclauss cclauss self-assigned this Jan 29, 2021
@cclauss cclauss mentioned this issue Jan 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cclauss cclauss

Labels
Lead: @cclauss Issues overseen by Chris (Python3 & Dev-ops lead 2019-2021) [managed] Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
Sprint 2021-01
Development

Successfully merging a pull request may close this issue.

Use empty str instead of None in HTTP headers cclauss/infogami
1 participant
@cclauss