Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Borrowing a book that is only on IA (not on OL) causes errors when viewing my books page #10047

Closed
cdrini opened this issue Nov 19, 2024 · 1 comment · Fixed by #10048
Closed

Borrowing a book that is only on IA (not on OL) causes errors when viewing my books page #10047

cdrini opened this issue Nov 19, 2024 · 1 comment · Fixed by #10048
Assignees
@cdrini
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 2 Important, as time permits. [managed] Type: Bug Something isn't working. [managed]
Milestone
Sprint 2024-11

Comments

@cdrini
Copy link
Collaborator

cdrini commented Nov 19, 2024

Problem

image

Reproducing the bug

  1. Borrow a book only on IA, eg https://archive.org/details/isbn_9781849352260
  2. Try to go to my books
  • Expected behavior: My books loads normally
  • Actual behavior: My books errors

Context

  • Browser (Chrome, Safari, Firefox, etc): FF
  • OS (Windows, Mac, etc): Win
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders

Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@cdrini cdrini added Type: Bug Something isn't working. [managed] Priority: 2 Important, as time permits. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] labels Nov 19, 2024
@cdrini cdrini added this to the Sprint 2024-11 milestone Nov 19, 2024
@cdrini cdrini self-assigned this Nov 19, 2024
@cdrini cdrini mentioned this issue Nov 19, 2024
Merged
@tfmorris
Copy link
Contributor

Why isn't that scan linked to this work? https://openlibrary.org/works/OL21284005W

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdrini cdrini

Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 2 Important, as time permits. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
Sprint 2024-11
Development

Successfully merging a pull request may close this issue.

Fix My Books erroring when IA-only book borrowed cdrini/openlibrary
2 participants
@tfmorris @cdrini