Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pageChanged event name into events.js #460

Open
iisa opened this issue Sep 30, 2020 · 14 comments · May be fixed by #461 or #1258
Open

Move pageChanged event name into events.js #460

iisa opened this issue Sep 30, 2020 · 14 comments · May be fixed by #461 or #1258
Labels
good first issue

Comments

@iisa
Copy link
Contributor

iisa commented Sep 30, 2020

Task:

  • Update events 'list' to include new field: pageChanged = 'pageChanged';
  • find all the places pageChanged is used, and point it to its new reference (events.pageChanged)
  • Make sure that the event BookReader:pageChanged is emitted when changing the page
  • Make sure all tests pass

https://github.com/internetarchive/bookreader/blob/master/src/js/BookReader/events.js
@nynaalekhya
Copy link

Hi,
I would like to take up this issue. Could this be assigned to me @iisa

@sfal sfal linked a pull request Sep 30, 2020 that will close this issue
Open
@iisa
Copy link
Contributor Author

iisa commented Oct 3, 2020

hi @nynaalekhya i apologize for not getting you assigned quickly. We will go with the current PR that is open since it is being worked on.
Would you like to take this one instead? #487

@ArunTeltia
Copy link
Contributor

@iisa mam can you assign a issue to me as well please

@DhairyaBahl
Copy link

@iisa if this issue is still available kindly assign it to me. Thanks :)

Chaitanya31612 pushed a commit to Chaitanya31612/bookreader that referenced this issue Nov 22, 2020
Move event name into events.js internetarchive#460
0a5f4e6
@Chaitanya31612
Copy link

@iisa Please review my pull request and guide for further changes. #559

Chaitanya31612 pushed a commit to Chaitanya31612/bookreader that referenced this issue Dec 1, 2020
Move event name into events.js internetarchive#460
4c0a8d9
Chaitanya31612 pushed a commit to Chaitanya31612/bookreader that referenced this issue Dec 1, 2020
Move event name into events.js internetarchive#460
bd3a09c
@Chaitanya31612
Copy link

Chaitanya31612 commented Dec 1, 2020 •
edited
Loading

@iisa Please review my pull request and guide for further changes. #559

@iisa I've made pull request of requested changes. please review it and guide for any other change whatsoever is required. #559

@harshhx
Copy link

harshhx commented Dec 21, 2020

I would like to take this issue.

@hkumar0132
Copy link

I would like to work on this issue if it's still open @iisa
I have been doing web development in javascript for a year now and would like to enter the open source world.

@codewithsantosh
Copy link

Mam,Can i solve this issue

@vishwjeet-singh
Copy link

Mam, May I work on this issue?

@Abhir-24 Abhir-24 mentioned this issue Mar 14, 2021
Closed
@Priyaraj17
Copy link

Is this issue open? I would like to work on it.

This was referenced Mar 17, 2021
Closed
Open
@GeraAlcantara
Copy link

close the issue please if is resolve

@vishavsingla
Copy link

Is this issue still open? I would like to work on it.

@umangutkarsh umangutkarsh linked a pull request Oct 13, 2023 that will close this issue
Open
@devansh-dek
Copy link

Is the issue still open? Can I work on It?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move pageChanged event name into events.js
Fix/#460: pageChanged-mods umangutkarsh/bookreader