Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rounding of columns with numeric values #100

Open
heralden opened this issue Aug 10, 2020 · 7 comments
Open

Support rounding of columns with numeric values #100

heralden opened this issue Aug 10, 2020 · 7 comments
Labels
enhancement InterMine backend Requires/depends on InterMine backend work. next release Should be adressed in the next release

Comments

@heralden
Copy link
Member

If a column is numeric, a button should appear in its column header that allows rounding of the numbers to a chosen decimal point. This rounding will only apply to the values of this column, on this specific table.

@AdrianBZG
Copy link
Member

AdrianBZG commented Aug 10, 2020

Also, an option to round all numbers in all columns by default would be helpful, otherwise the user would need to be clicking the round button in every column each time a page is accessed.

@heralden
Copy link
Member Author

The team thought that having it by default wouldn't be a good idea.

I guess the middle ground would be to have it global then. I think there are some different approaches:

  • Should it be configured by a user to apply to all instances of that column in all im-tables in Bluegenes?
  • Should a mine admin configure a default, i.e. they set which columns (by path) should be rounded and to which decimal?

I'm guessing the second one is what you want?

@AdrianBZG
Copy link
Member

Yes, the second one sounds like a good approach, although that would mean specifying columns path by path. In some sources I have more than 20 columns with decimal numbers, so that's why I was suggesting to also have some kind of global rounding option. But it's fine to go with the second option you mention.

@heralden
Copy link
Member Author

heralden commented Aug 11, 2020

Do those 20 columns point to the same class? If so we could instead specify rounding for classes.

Edit: The rounding should be specified for an attribute of a class.

@AdrianBZG
Copy link
Member

Yes, they belong all to the same class

@heralden
Copy link
Member Author

Sounds good! We'll have to figure out where this should be defined, but I'm guessing it will be in a property file on the Intermine backend.

@heralden heralden added next release Should be adressed in the next release enhancement labels Aug 12, 2020
@heralden heralden added the InterMine backend Requires/depends on InterMine backend work. label Aug 24, 2020
@danielabutano
Copy link
Member

We can use the webconfig_model.xml file, in the mine instance, to add the new property rounding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement InterMine backend Requires/depends on InterMine backend work. next release Should be adressed in the next release
Projects
None yet
Development

No branches or pull requests

3 participants