-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support rounding of columns with numeric values #100
Comments
Also, an option to round all numbers in all columns by default would be helpful, otherwise the user would need to be clicking the round button in every column each time a page is accessed. |
The team thought that having it by default wouldn't be a good idea. I guess the middle ground would be to have it global then. I think there are some different approaches:
I'm guessing the second one is what you want? |
Yes, the second one sounds like a good approach, although that would mean specifying columns path by path. In some sources I have more than 20 columns with decimal numbers, so that's why I was suggesting to also have some kind of global rounding option. But it's fine to go with the second option you mention. |
Do those 20 columns point to the same class? If so we could instead specify rounding for classes. Edit: The rounding should be specified for an attribute of a class. |
Yes, they belong all to the same class |
Sounds good! We'll have to figure out where this should be defined, but I'm guessing it will be in a property file on the Intermine backend. |
We can use the webconfig_model.xml file, in the mine instance, to add the new property rounding |
If a column is numeric, a button should appear in its column header that allows rounding of the numbers to a chosen decimal point. This rounding will only apply to the values of this column, on this specific table.
The text was updated successfully, but these errors were encountered: