Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(background)!: better payment confirmation & message #694

Merged
merged 36 commits into from
Nov 27, 2024
Merged

fix(background)!: better payment confirmation & message #694

merged 36 commits into from
Nov 27, 2024

Commits on Nov 1, 2024

  1. fix(background)!: better payment confirmation message

    @sidvishnoi
    sidvishnoi committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    c9ddb61 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. wait before first attempt; rename function

    @sidvishnoi
    sidvishnoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    05efcb0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into payment-confirmation

    @sidvishnoi
    sidvishnoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    28d4b03 View commit details
    Browse the repository at this point in the history

  3. make PaymentSession.pay always return OutgoingPayment; retry/throw ot… 

    …herwise
    @sidvishnoi
    sidvishnoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    244ab38 View commit details
    Browse the repository at this point in the history

  4. try different signature: get last outgoingPayment regardless of error

    @sidvishnoi
    sidvishnoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    2148d3f View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Merge branch 'main' into payment-confirmation

    @sidvishnoi
    sidvishnoi committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a0ee3c6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into payment-confirmation

    @sidvishnoi
    sidvishnoi committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    30eb935 View commit details
    Browse the repository at this point in the history

  3. use async generator in polling; handle more errors; more abstraction

    @sidvishnoi
    sidvishnoi committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    465ba9c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into payment-confirmation

    @sidvishnoi
    sidvishnoi committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    951dc74 View commit details
    Browse the repository at this point in the history

  5. require only outgoingPaymentId in polling 

    In case we decide to do the polling separately, we don't need to store
entire initial outgoingPayment for reference.
    @sidvishnoi
    sidvishnoi committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    52abeaa View commit details
    Browse the repository at this point in the history

  6. nit 

    [ci skip]
    @sidvishnoi
    sidvishnoi committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c96aa90 View commit details
    Browse the repository at this point in the history

  7. nit: style/import 

    [ci skip]
    @sidvishnoi
    sidvishnoi committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    48cf703 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. ui & message improvements

    @sidvishnoi
    sidvishnoi committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    6f93b1c View commit details
    Browse the repository at this point in the history

  2. use same error message for OutgoingPayment.failed = true

    @sidvishnoi
    sidvishnoi committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    d4e89fd View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Merge branch 'main' into payment-confirmation

    @sidvishnoi
    sidvishnoi committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d57f918 View commit details
    Browse the repository at this point in the history

  2. reduce polling initial delay from 2.5s to 1.5s

    @sidvishnoi
    sidvishnoi committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    4b13c73 View commit details
    Browse the repository at this point in the history

  3. walletAddress check

    @sidvishnoi
    sidvishnoi committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    a0768ee View commit details
    Browse the repository at this point in the history

  4. fix typo in error key name

    @sidvishnoi
    sidvishnoi committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    e11cf13 View commit details
    Browse the repository at this point in the history

  5. comment on null assertion

    @sidvishnoi
    sidvishnoi committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    3df3acd View commit details
    Browse the repository at this point in the history

  6. use payStatus full/partial instead of success/warn; also in bg

    @sidvishnoi
    sidvishnoi committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    cba0301 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Merge branch 'main' into payment-confirmation

    @sidvishnoi
    sidvishnoi committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d1e3681 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Merge branch 'main' into payment-confirmation

    @sidvishnoi
    sidvishnoi committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    bca0dbf View commit details
    Browse the repository at this point in the history

  2. update comment for isMissingGrantPermissionsError

    @sidvishnoi
    sidvishnoi committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    6560b41 View commit details
    Browse the repository at this point in the history

  3. handle case isMissingGrantPermissionsError is actually isTokenInactiv… 

    …eError
    @sidvishnoi
    sidvishnoi committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    387cc08 View commit details
    Browse the repository at this point in the history

  4. update success/failure states; add partial status; update msgs

    @sidvishnoi
    sidvishnoi committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    715746e View commit details
    Browse the repository at this point in the history

  5. update success message to remove URL

    @sidvishnoi
    sidvishnoi committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    2979f04 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Merge branch 'main' into payment-confirmation

    @sidvishnoi
    sidvishnoi committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    34ac427 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Merge branch 'main' into payment-confirmation

    @sidvishnoi
    sidvishnoi committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    b626ad3 View commit details
    Browse the repository at this point in the history

  2. use opacity animation on message, slide is distracting

    @sidvishnoi
    sidvishnoi committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    3021b41 View commit details
    Browse the repository at this point in the history

  3. fix disabled styles

    @sidvishnoi
    sidvishnoi committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    3c8434c View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Merge branch 'main' into payment-confirmation

    @sidvishnoi
    sidvishnoi committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    d2ae2ce View commit details
    Browse the repository at this point in the history

  2. update _locales key description

    @sidvishnoi
    sidvishnoi committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    6efb7ba View commit details
    Browse the repository at this point in the history

  3. handle insufficient grant by checking token's access values

    @sidvishnoi
    sidvishnoi committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    9032cc4 View commit details
    Browse the repository at this point in the history

  4. add todo comment

    @sidvishnoi
    sidvishnoi committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    fb115d1 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Merge branch 'main' into payment-confirmation

    @sidvishnoi
    sidvishnoi authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    0678549 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Merge branch 'main' into payment-confirmation

    @sidvishnoi
    sidvishnoi authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    5347047 View commit details
    Browse the repository at this point in the history