Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(testing/plan): add functional test plan #596

Merged
merged 52 commits into from
Nov 21, 2024
Merged

Conversation

tselit
Copy link
Contributor

@tselit tselit commented Sep 13, 2024

Context

Document a test plan for the Web Monetization extension, detailing the functional test cases.

Closes #290.

Changes proposed in this pull request

The test plan in markdown format, alongside an image asset that visualises how the test cases relate to each other.

add test plan
Add 7 sections.
Add risks and test case diagram
add assets for testing
add a mindmap of the test cases
this folder was meant to be in the test/testplan folder
a folder for the test plan assets
add 3 basic test cases
Added the following test cases:
- Pay one-time when extension funds are insufficient.
- Disable continuous payments.
Added the following 4 test cases: 
- Pay one-time when extension funds are insufficient
- Disable continuous payments
- Change rate of pay and View available balance
- Disconnect wallet
- update test case for a partial one-time payment success due to insufficient extension funds
- add test case to pay until the extension runs out of funds
@tselit tselit added the area: documentation Improvements or additions to documentation label Sep 13, 2024
@tselit tselit added this to the Public Beta release milestone Sep 13, 2024
@tselit tselit removed this from the Public Beta release milestone Sep 13, 2024
Copy link
Contributor

github-actions bot commented Sep 13, 2024

Extension builds preview

Name Link
Latest commit 5c97b31
Latest job logs Run #11954024807
BadgeDownload
BadgeDownload

@tselit tselit changed the title docs (test plan/functional tests): 8 basic test cases & 3 edge test cases docs: functional test plan Sep 13, 2024
**Steps**:

1. Visit a monetized website that has multiple receiving wallet addresses or payment pointers:
a. You can visit [roamancing.com/naturallyours](http://roamancing.com/naturallyours/).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should say how many wallet addresses are in this page and whether they're real or test. This way, under expected results, the user will know how to math the remaining balance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, cool.

b. Alternatively, you can use the [Test Playground](#Test-Playground) to add payment pointers or wallet addresses from different wallet providers.
As an example, you can add all of the following wallet addresses to the playground:

- https://ilp.rafiki.money/wm-dev

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this address need to change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the test playground alternative from the functional test cases.
I think the test case text is less cluttered, and reads a little easier.

- [storytogo.ca](https://storytogo.ca)
- [roamancing.com](https://roamancing.com)

2. Visit the Web Monetization Playground, and add any Fynbos Canada wallet addresses. Here are a few payment pointers that you can use:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Fynbos Canada reference here is supposed to be Gatehub.

**Expected results**:

1. The wallet owner receives an interaction prompt from their wallet to authorize the connection and access to the amount.
2. On accepting, you get shown the message "Your wallet is now successfully connected to the extension."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge thing, but step 1 references the wallet owner and step 2 references "you". These references refer to the same person.


| Web monetized websites | Non monetized websites |
| :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | :------------------------------------------------------------------------------ |
| Extension icon: active (full color), with a green tick | Extension icon: active (full color), but with a red X |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test ID 3 below shows an image for non web monetized websites. None of the other tables contain any other assets. Was this intentional?

Copy link

@melissahenderson melissahenderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a final round of comments/questions. In general, I think you're just about there so I'm approving this.

tselit and others added 6 commits November 19, 2024 14:29
* chore(deps): update dependency tsx to ^4.19.2 (#715)

* chore(deps): update dependency @testing-library/jest-dom to ^6.6.3 (#717)

* fix(deps): update dependency react-router-dom to ^6.28.0 (#718)

* chore(deps): update dependency tailwind-merge to ^2.5.4 (#716)

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@tselit tselit removed the request for review from RabebOthmani November 21, 2024 13:19
@tselit tselit merged commit f330f26 into main Nov 21, 2024
8 checks passed
@tselit tselit deleted the mt/docs/test/testplan branch November 21, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functional testing doc - beta release
3 participants