Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tower-service #434

Open
emschwartz opened this issue Oct 17, 2019 · 1 comment
Open

Use tower-service #434

emschwartz opened this issue Oct 17, 2019 · 1 comment

Comments

@emschwartz
Copy link
Member

We should consider getting rid of the interledger-service::{IncomingService,OutgoingService} traits and switching everything to tower-service.

When I started working on Interledger.rs, tower:

  • still seemed like a work in progress
  • didn't have any middleware I needed
  • would have added more generics to the stack of services comprising Interledger.rs

Now, the tower ecosystem is farther along and we should consider switching. That said, it's probably worth waiting until v0.3.x is released and until we switch to std::Future(#142).

@gakonst
Copy link
Member

gakonst commented Oct 18, 2019

I agree that we should tackle this as soon as we move to futures 0.3 and while generally transitioning to async/await.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants