Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass blockHash to parseRequest methods #599

Open
gregdhill opened this issue Mar 7, 2023 · 0 comments
Open

Pass blockHash to parseRequest methods #599

gregdhill opened this issue Mar 7, 2023 · 0 comments
Labels
prio:medium

Comments

@gregdhill
Copy link
Member

The methods that call this function read only from the finalized head but when parsing the requests we check the latest unfinalized state, this shouldn't be an issue in practice but it is better to be consistent and read from the same height.
@nud3l nud3l added this to Backlog Mar 7, 2023
@github-project-automation github-project-automation bot moved this to New 🆕 in Backlog Mar 7, 2023
@gregdhill gregdhill mentioned this issue Mar 7, 2023
Merged
@bvotteler bvotteler added bug Something isn't working prio:medium labels Mar 7, 2023
@gregdhill gregdhill removed the bug Something isn't working label Mar 7, 2023
@gregdhill gregdhill mentioned this issue Mar 9, 2023
Merged
@nud3l nud3l moved this from New 🆕 to Todo ⏳ in Backlog Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio:medium
Projects
Backlog
Status: Todo ⏳
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregdhill @bvotteler