New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DI the \Bugsnag\Client in the ExceptionCatcher class? #17

Open

Stoux opened this issue Sep 30, 2019 · 0 comments

Stoux commented Sep 30, 2019

I was wondering why the Bugsnag client isn't DI'd but created on the spot: https://github.com/interjar/bugsnag-magento2/blob/master/Plugin/ExceptionCatcher.php#L51-L54
Upside of it being DI'd in the constructor is that anyone can extend the Client? Are there any downsides to it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment