Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should prettier be a hard requirement? #32

Closed
antoniolibrada opened this issue Apr 29, 2020 · 3 comments
Closed

Should prettier be a hard requirement? #32

antoniolibrada opened this issue Apr 29, 2020 · 3 comments

Comments

@antoniolibrada
Copy link

Hello !

I have been trying your script and I have gotten an error saying that I needed to install prettier. Can you state that as a dependency or in the documentation?

I will probably do it afterwards if I get time.

Thanks :)

@antoniolibrada
Copy link
Author

I have seen, it is a peer dependency... Silly me

@mathieutu
Copy link

Actually maybe it shouldn't be? It's cool to format with prettier if we have it, but force us to install it just for the script is bit much, don't you think?

Thanks.

@lorenzogm
Copy link

This is an example why prettier shouldn't be required: https://github.com/valtech-ch/ring/runs/2858342339?check_suite_focus=true

I need to install prettier and delay the action more than minute

image

it would be nice to have a parameter to disable it. Do you accept a PR for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants