max_plugin_restarts is not allowed as a parameter in global config

[katarzyna-z]

max_plugin_restarts is not allowed as a parameter in global config.

Steps to reproduce:

1. install snap-telemetry

$ curl -s https://packagecloud.io/install/repositories/intelsdi-x/snap/script.deb.sh | sudo bash
$ sudo apt-get install -y snap-telemetry
$ sudo systemctl stop snap-telemetry

2. edit snapteld.conf to this version

3. start snap-telemetry

$ sudo systemctl start snap-telemetry

4. check status

$ sudo systemctl status snap-telemetry
● snap-telemetry.service - Snap telemetry daemon
   Loaded: loaded (/lib/systemd/system/snap-telemetry.service; disabled; vendor preset: enabled)
   Active: inactive (dead)
     Docs: man:snapteld(8)
           man:snaptel(1)

Feb 02 11:50:16 ******** kill[26427]:  -h, --help     display this help and exit
Feb 02 11:50:16 ******** kill[26427]:  -V, --version  output version information and exit
Feb 02 11:50:16 ******** kill[26427]: For more details see kill(1).
Feb 02 11:50:16 ******** systemd[1]: snap-telemetry.service: Control process exited, code=exited status=1
Feb 02 11:50:16 ******** systemd[1]: snap-telemetry.service: Unit entered failed state.
Feb 02 11:50:16 ******** systemd[1]: snap-telemetry.service: Failed with result 'exit-code'.
Feb 02 11:50:16 ******** systemd[1]: snap-telemetry.service: Service hold-off time over, scheduling restart.
Feb 02 11:50:16 ******** systemd[1]: Stopped Snap telemetry daemon.
Feb 02 11:50:16 ******** systemd[1]: snap-telemetry.service: Start request repeated too quickly.
Feb 02 11:50:16 ******** systemd[1]: Failed to start Snap telemetry daemon.

5. check logs

$ cat syslog | grep snap
...
Feb  2 11:50:16 ******** snapteld[26418]: time="2017-02-02T11:50:16+01:00" level=error msg="Validate schema error" context="(root)::control" description="Additional property max_plugin_restarts is not allowed" value=map[auto_discover_path:/opt/snap/plugins max_plugin_restarts:10 plugin_trust_level:0]
Feb  2 11:50:16 ******** snapteld[26418]: time="2017-02-02T11:50:16+01:00" level=fatal msg="Errors found while parsing global configuration file"
Feb  2 11:50:16 ******** systemd[1]: snap-telemetry.service: Main process exited, code=exited, status=1/FAILURE
...

[IRCody]

I think this is feature exists on master but isn't part of the latest release because the PR making max_plugin_restarts configurable was a merged a few days after 1.0. See: #1246 fixed by #1422.