You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
When debugging #1448, we tried to suspend/resume process via kill -STOP & kill -CONT. This uncovered some issues with how we start plugin processes. After several heartbeat failures, if the plugin process is resumed, snap will terminate it, but spawn multiple plugin processes.
When debugging #1448, we tried to suspend/resume process via
kill -STOP
&kill -CONT
. This uncovered some issues with how we start plugin processes. After several heartbeat failures, if the plugin process is resumed, snap will terminate it, but spawn multiple plugin processes.We should guard this by ensuring this block of code is not executed simultaneously by multiple plugin failure events:
https://github.com/intelsdi-x/snap/blob/master/control/runner.go#L246-L281
This can be done crudely by a mutex lock and defer unlock around that section of code.
The text was updated successfully, but these errors were encountered: