Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Report @penn5 #10

Open
Netkas opened this issue Nov 3, 2019 · 3 comments
Open

User Report @penn5 #10

Netkas opened this issue Nov 3, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@Netkas
Copy link
Contributor

Netkas commented Nov 3, 2019

The server appears to always return available:true
even when the expiry date is passed, sessions are available

@Netkas Netkas added the bug Something isn't working label Nov 3, 2019
@Netkas Netkas self-assigned this Nov 3, 2019
@Netkas
Copy link
Contributor Author

Netkas commented Nov 3, 2019

Will look into it when I have the time today

@Netkas
Copy link
Contributor Author

Netkas commented Nov 3, 2019

The reason for available returning true even when the session has expired is because the property available is altered when the session becomes unavailable.

A session becomes unavailable due to an error in CoffeeHouse, a fatal exception. By default CoffeeHouse does not alter this variable to become false when the session expires

Because when the session expires the session in theory could still work, but for optimal reasons it's best to make the session unavailable when it has expired.

I'll apply a patch to fix this

@Netkas
Copy link
Contributor Author

Netkas commented Nov 3, 2019

This issue has been fixed in commit 9250a58

Assuming that @AntiEngineer has applied patches to this before without committing, you should apply your patches now.

When done, patches or no patches; push to production. kthxbye

@Netkas Netkas assigned libinit and unassigned Netkas Nov 3, 2019
@libinit libinit assigned libinit and unassigned libinit May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants