Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize diagnosing in job manager #1365

Conversation

BalaBalaYi
Copy link
Collaborator

What changes were proposed in this pull request?

  1. Use noun to naming thread.
  2. Simplify '_diagnose_job' and '_monitor_node_heart_beat'.

Why are the changes needed?

Optimization.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT.

@BalaBalaYi BalaBalaYi added the enhancement New feature or request label Nov 28, 2024
@BalaBalaYi BalaBalaYi added this to the v0.4.0 milestone Nov 28, 2024
Copy link
Collaborator

@samplise samplise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BalaBalaYi BalaBalaYi merged commit b39ce89 into intelligent-machine-learning:master Nov 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants