Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move atorch and tfplus into independent projects #1360

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

mingcheng
Copy link
Collaborator

@mingcheng mingcheng commented Nov 27, 2024

reopen the closed pr #1359

fyi: #1358 and the mentioned project has migrated to

So, this pr will clean the old codes and import the library as git modules.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.22%. Comparing base (0674b71) to head (0e45a02).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1360      +/-   ##
==========================================
- Coverage   81.23%   81.22%   -0.02%     
==========================================
  Files         231      231              
  Lines       22116    22116              
==========================================
- Hits        17967    17964       -3     
- Misses       4149     4152       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
@mingcheng mingcheng changed the title move atorch and tfplus into indepented projects and import as git submodules move atorch and tfplus into indepented projects Nov 27, 2024
@mingcheng mingcheng changed the title move atorch and tfplus into indepented projects move atorch and tfplus into independent projects Nov 27, 2024
@workingloong
Copy link
Collaborator

Also remove atorch-python-test.

@mingcheng
Copy link
Collaborator Author

Also remove atorch-python-test.

I have checked this test item and found codecov cached this case. I temporarily disable the app for the cache to clean by itself for a while.

Copy link
Collaborator

@workingloong workingloong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mingcheng mingcheng force-pushed the move-librarys-into-indepented-projects branch from 8cd2b73 to 4563d45 Compare November 27, 2024 11:22
@antfin-oss
Copy link
Contributor

Also remove atorch-python-test.

I have checked this test item and found codecov cached this case. I temporarily disable the app for the cache to clean by itself for a while.

This is a configuration issue. fixed

@BalaBalaYi BalaBalaYi removed enhancement New feature or request help wanted Extra attention is needed labels Nov 27, 2024
@majieyue majieyue self-requested a review November 27, 2024 11:36
Copy link
Collaborator

@majieyue majieyue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scripts/codecov.sh Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@mingcheng mingcheng force-pushed the move-librarys-into-indepented-projects branch from 0996ab9 to 9819d09 Compare November 27, 2024 11:55
@antfin-oss antfin-oss self-requested a review November 27, 2024 12:44
.github/workflows/main.yml Outdated Show resolved Hide resolved
@skydoorkai skydoorkai self-requested a review November 28, 2024 02:14
Copy link
Collaborator

@skydoorkai skydoorkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mingcheng mingcheng force-pushed the move-librarys-into-indepented-projects branch from 9819d09 to 3799930 Compare November 28, 2024 02:45
@mingcheng
Copy link
Collaborator Author

updated the commit history and removed some unnecessary or redundant messages.

@antfin-oss antfin-oss merged commit 35cbcc2 into master Nov 28, 2024
7 checks passed
@antfin-oss antfin-oss deleted the move-librarys-into-indepented-projects branch November 28, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants