Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

[DNNL] implement RESIZE_BILINEAR #461

Closed
huningxin opened this issue Jan 15, 2019 · 11 comments
Closed

[DNNL] implement RESIZE_BILINEAR #461

huningxin opened this issue Jan 15, 2019 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@huningxin
Copy link
Contributor

No description provided.

@huningxin huningxin added the enhancement New feature or request label Jan 15, 2019
@huningxin huningxin added this to the Jan 2019 milestone Jan 15, 2019
@huningxin huningxin self-assigned this Jan 15, 2019
@huningxin huningxin modified the milestones: Jan 2019, Mar 2019 Feb 15, 2019
@huningxin
Copy link
Contributor Author

MKLDNN doesn't provide resize bilinear primitive. I'd like to mark it low priority before MKLDNN supports it natively.

@huningxin huningxin removed this from the Mar 2019 milestone Apr 2, 2019
@ibelem ibelem added the p1 Highest priority label Aug 27, 2019
@pinzhenx
Copy link
Contributor

pinzhenx commented Nov 8, 2019

Will be available in v1.2 oneapi-src/oneDNN#563

@huningxin
Copy link
Contributor Author

Will be available in v1.2 intel/mkl-dnn#563

@pinzhenx , thanks for this info!

@huningxin huningxin removed the p1 Highest priority label Nov 20, 2019
@ibelem
Copy link
Member

ibelem commented Dec 13, 2019

@lisa0314 @huningxin @pinzhenx @BruceDai @fujunwei @Christywl Based on oneapi-src/oneDNN#563, it has been implemented in oneapi-src/oneDNN@16b9a5d . Since all the performance test failed for Semantic Segmentation, please consider to implement this op.

@ibelem ibelem changed the title [MKLDNN] implement RESIZE_BILINEAR [DNNL] implement RESIZE_BILINEAR Dec 13, 2019
@ibelem ibelem added this to the December, 2019 milestone Dec 17, 2019
@ibelem ibelem modified the milestones: December, 2019, January 2020 Dec 31, 2019
@lisa0314
Copy link
Contributor

lisa0314 commented Jan 6, 2020

@belem I found that the argmax op will block the testing for Semantic Segmention after I implemented resize_bilinear.

@ibelem
Copy link
Member

ibelem commented Jan 7, 2020

@BruceDai @Christywl , is that possible to provide old models for Lisha to run the testing? Any other test ways?

@huningxin
Copy link
Contributor Author

I remember we agreed to make the semantic segmentation example works for backends with argmax op supported and not supported. What's the status of that? @BruceDai

@BruceDai
Copy link
Contributor

BruceDai commented Jan 7, 2020

@huningxin As previous discussions, we use dual backend to run updated models with argmax op if argmax op wasn't implemented by WebNN sides.

@BruceDai
Copy link
Contributor

BruceDai commented Jan 7, 2020

@ibelem I provided those models without argmax ops to @lisa0314 yesterday. And I sent the mail to @lisha with the old test server URL for semantic segmentation example without argmax.

@huningxin
Copy link
Contributor Author

@lisa0314 , I think this one should be closed by otcshare/chromium-src#24, correct?

@lisa0314
Copy link
Contributor

@huningxin yes, it should be closed and I will close this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants