This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
operator testing #744
Merged
operator testing #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"should" is not strong enough. It "must" match.
The operator had a bug where its change detection caused it to update objects unnecessarily. This wasn't caught before by the tests because the modified objects still had the expected content (as far as we know, at least - intel#742 still lacks a proper explanation). Now the update unit test catches that bug: TestDeploymentController/Kubernetes_1.18/updating/pmemPercentage_in_default_deployment: deployment_controller_test.go:264: Error Trace: deployment_controller_test.go:264 deployment_controller_test.go:559 deployment_controller_test.go:584 Error: Received unexpected error: deployed driver different from expected deployment: object was modified unnecessarily: "pmem-csi-with-defaults-node" of type "apps/v1, Kind=DaemonSet" in namespace "test-namespace" object was modified unnecessarily: "pmem-csi-with-defaults-controller" of type "apps/v1, Kind=StatefulSet" in namespace "test-namespace" Test: TestDeploymentController/Kubernetes_1.18/updating/pmemPercentage_in_default_deployment Messages: validate deployment We cannot use the same validation during E2E testing because the app controllers also modify the objects by setting their status.
pohly
force-pushed
the
operator-testing
branch
from
742c379 to
48a0250
Compare
avalluri
approved these changes
Sep 25, 2020
These 10 seconds are not applied when using |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the regression test for PR #743.
Also includes one drive-by comment fix.