Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print PIDs and exit status in decimal #522

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Print PIDs and exit status in decimal #522

merged 1 commit into from
Mar 6, 2023

Conversation

heatd
Copy link
Contributor

@heatd heatd commented Mar 2, 2023

Also add a trailing newline for the child-SIGNALED case.

Also add a trailing newline for the child-SIGNALED case.
@jrtc27
Copy link

jrtc27 commented Mar 2, 2023

Isn't decimal the default? This smells like somewhere else used std::hex and didn't reset it back.

@heatd
Copy link
Contributor Author

heatd commented Mar 2, 2023

Example of (old) bad output:
Program sleep launched with PID: b69b
Process b69b was terminated with status 2Time elapsed: 1054 ms

@heatd
Copy link
Contributor Author

heatd commented Mar 2, 2023

Isn't decimal the default? This smells like somewhere else used std::hex and didn't reset it back.

Yes, yes it is. I don't know if the project's "iostream usage pattern" always resets it back to std::dec, but from a quick grep I could find a few usages here and there that do not.

@opcm opcm merged commit f20013f into intel:master Mar 6, 2023
rdementi added a commit that referenced this pull request Jan 24, 2024
* pcm-numa add -c option, pcm-msr add a few options

---------

Authored-by: Galbi, Duane E <[email protected]>
rdementi added a commit that referenced this pull request Jan 24, 2024
* pcm-numa add -c option, pcm-msr add a few options

---------

Authored-by: Galbi, Duane E <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants