Skip to content
This repository has been archived by the owner on Aug 20, 2020. It is now read-only.

Fullscreen support #128

Closed
etrunko opened this issue Nov 13, 2013 · 15 comments
Closed

Fullscreen support #128

etrunko opened this issue Nov 13, 2013 · 15 comments
Assignees

Comments

@etrunko
Copy link
Contributor

etrunko commented Nov 13, 2013

Add support for toggling windows fullscreen.

Dependency: #112.
Blocks: #4 .
Sub-Tasks: None.

@ghost ghost assigned etrunko Nov 13, 2013
@kalyankondapally
Copy link
Contributor

Note that #112 needs to be fixed first before starting on this work. I will be coming to that soon as it needs to be handled with offscreen support.

@etrunko
Copy link
Contributor Author

etrunko commented Nov 18, 2013

Here is what it should look like:

etrunko/ozone-wayland@e47c306 Implement Fullscreen mode

This is causing the program to abort for some reason. The log is the following:

[17492:17492:1118/172437:INFO:desktop_factory_wayland.cc(13)] Ozone: DesktopFactoryWayland
[17:24:37.905] libwayland: disconnect from client 0x1aef5a0
[17534:17534:1118/172438:INFO:desktop_factory_wayland.cc(13)] Ozone: DesktopFactoryWayland
[17492:17492:1118/172438:ERROR:desktop_root_window_host_wayland.cc(440)] Not implemented reached in virtual void ozonewayland::DesktopRootWindowHostWayland::InitModalType(ui::ModalType)
[17492:17492:1118/172438:ERROR:desktop_drag_drop_client_wayland.cc(15)] Not implemented reached in ozonewayland::DesktopDragDropClientWayland::DesktopDragDropClientWayland(aura::Window*)
[17492:17492:1118/172438:ERROR:desktop_root_window_host_wayland.cc(457)] Not implemented reached in virtual void ozonewayland::DesktopRootWindowHostWayland::OnNativeWidgetFocus()
[17492:17492:1118/172438:ERROR:desktop_root_window_host_wayland.cc(465)] Not implemented reached in virtual bool ozonewayland::DesktopRootWindowHostWayland::IsAnimatingClosed() const
[17492:17492:1118/172438:ERROR:desktop_root_window_host_wayland.cc(453)] Not implemented reached in virtual void ozonewayland::DesktopRootWindowHostWayland::OnRootViewLayout() const
[17492:17492:1118/172438:ERROR:desktop_root_window_host_wayland.cc(453)] Not implemented reached in virtual void ozonewayland::DesktopRootWindowHostWayland::OnRootViewLayout() const
[17534:17534:1118/172438:ERROR:gl_surface_egl.cc(534)] eglCreatePbufferSurface failed with error EGL_SUCCESS
[17534:17534:1118/172438:ERROR:gpu_command_buffer_stub.cc(447)] Failed to create surface.

[17492:17492:1118/172438:ERROR:command_buffer_proxy_impl.cc(164)] Failed to initialize command buffer service.
[17542:17542:1118/172438:ERROR:renderer_main.cc(227)] Running without renderer sandbox
[17534:17534:1118/172438:ERROR:gl_surface_egl.cc(259)] Trying to create surface without window.
[17534:17534:1118/172438:ERROR:gpu_command_buffer_stub.cc(447)] Failed to create surface.

[17492:17492:1118/172438:ERROR:command_buffer_proxy_impl.cc(164)] Failed to initialize command buffer service.
[17534:17534:1118/172438:ERROR:ozone_display.cc(274)] Not implemented reached in void ozonewayland::OzoneDisplay::OnWidgetStateChanged(gfx::AcceleratedWidget, ozonewayland::OzoneDisplay::WidgetState, unsigned int, unsigned int)
[17534:17534:1118/172438:ERROR:gl_surface_egl.cc(534)] eglCreatePbufferSurface failed with error EGL_SUCCESS
[17534:17534:1118/172438:ERROR:gpu_command_buffer_stub.cc(447)] Failed to create surface.

[17492:17492:1118/172438:ERROR:command_buffer_proxy_impl.cc(164)] Failed to initialize command buffer service.
[17562:17562:1118/172438:ERROR:renderer_main.cc(227)] Running without renderer sandbox
[17534:17534:1118/172438:ERROR:ozone_display.cc(268)] Not implemented reached in void ozonewayland::OzoneDisplay::OnWidgetStateChanged(gfx::AcceleratedWidget, ozonewayland::OzoneDisplay::WidgetState, unsigned int, unsigned int)
[17492:17508:1118/172438:ERROR:gpu_message_filter.cc(189)] Renderer 3 tried to access a surface for renderer 0
[17492:17508:1118/172438:ERROR:gpu_message_filter.cc(189)] Renderer 3 tried to access a surface for renderer 0
[17492:17508:1118/172438:ERROR:gpu_message_filter.cc(189)] Renderer 3 tried to access a surface for renderer 0
[17492:17508:1118/172438:ERROR:gpu_message_filter.cc(189)] Renderer 3 tried to access a surface for renderer 0
[17492:17492:1118/172439:INFO:CONSOLE(1134)] "onStartup", source: chrome-extension://pafkbggdmjlpgkdkcbjmhmfcdpncadgh/background.js (1134)
[17492:17492:1118/172439:INFO:CONSOLE(491)] "Adding task show-cards-on-start", source: chrome-extension://pafkbggdmjlpgkdkcbjmhmfcdpncadgh/utility.js (491)
[17492:17492:1118/172439:INFO:CONSOLE(455)] "Starting task show-cards-on-start", source: chrome-extension://pafkbggdmjlpgkdkcbjmhmfcdpncadgh/utility.js (455)
[17492:17492:1118/172439:INFO:CONSOLE(491)] "Adding task state-changed", source: chrome-extension://pafkbggdmjlpgkdkcbjmhmfcdpncadgh/utility.js (491)
[17492:17492:1118/172439:INFO:CONSOLE(1141)] "onStartup-get {}", source: chrome-extension://pafkbggdmjlpgkdkcbjmhmfcdpncadgh/background.js (1141)
[17492:17492:1118/172439:INFO:CONSOLE(283)] "showNotificationCards {}", source: chrome-extension://pafkbggdmjlpgkdkcbjmhmfcdpncadgh/background.js (283)
[17492:17492:1118/172439:INFO:CONSOLE(287)] "showNotificationCards-get {"notificationsData":{},"recentDismissals":{}}", source: chrome-extension://pafkbggdmjlpgkdkcbjmhmfcdpncadgh/background.js (287)
[17492:17492:1118/172439:INFO:CONSOLE(294)] "showNotificationCards-getAll {}", source: chrome-extension://pafkbggdmjlpgkdkcbjmhmfcdpncadgh/background.js (294)
[17492:17492:1118/172439:INFO:CONSOLE(508)] "Finishing task show-cards-on-start", source: chrome-extension://pafkbggdmjlpgkdkcbjmhmfcdpncadgh/utility.js (508)
[17492:17492:1118/172439:INFO:CONSOLE(455)] "Starting task state-changed", source: chrome-extension://pafkbggdmjlpgkdkcbjmhmfcdpncadgh/utility.js (455)
[17492:17492:1118/172439:INFO:CONSOLE(1056)] "State Update signedIn=false geolocationEnabled=false canEnableBackground=true notificationEnabled=true googleNowEnabled=false", source: chrome-extension://pafkbggdmjlpgkdkcbjmhmfcdpncadgh/background.js (1056)
[17492:17492:1118/172439:INFO:CONSOLE(1080)] "Requested Actions shouldSetBackground=false setShouldPollCards=false", source: chrome-extension://pafkbggdmjlpgkdkcbjmhmfcdpncadgh/background.js (1080)
[17492:17492:1118/172439:INFO:CONSOLE(1032)] "Action Ignored setBackgroundEnable=false", source: chrome-extension://pafkbggdmjlpgkdkcbjmhmfcdpncadgh/background.js (1032)
[17492:17492:1118/172440:INFO:CONSOLE(1011)] "Action Ignored setShouldPollCards=false", source: chrome-extension://pafkbggdmjlpgkdkcbjmhmfcdpncadgh/background.js (1011)
[17492:17492:1118/172440:INFO:CONSOLE(508)] "Finishing task state-changed", source: chrome-extension://pafkbggdmjlpgkdkcbjmhmfcdpncadgh/utility.js (508)
[17492:17492:1118/172443:ERROR:desktop_root_window_host_wayland.cc(566)] Not implemented reached in virtual void ozonewayland::DesktopRootWindowHostWayland::SetCursor(gfx::NativeCursor)
[17492:17492:1118/172443:ERROR:desktop_root_window_host_wayland.cc(566)] Not implemented reached in virtual void ozonewayland::DesktopRootWindowHostWayland::SetCursor(gfx::NativeCursor)
[17492:17492:1118/172443:ERROR:desktop_root_window_host_wayland.cc(461)] Not implemented reached in virtual void ozonewayland::DesktopRootWindowHostWayland::OnNativeWidgetBlur()
[17492:17492:1118/172445:ERROR:fullscreen_aura.cc(15)] Not implemented reached in bool IsFullScreenMode()
[17:24:45.794] libwayland: disconnect from client 0x1aef5a0
[17492:17492:1118/172445:ERROR:gpu_process_transport_factory.cc(456)] Lost UI compositor context.
[17580:17580:1118/172446:INFO:desktop_factory_wayland.cc(13)] Ozone: DesktopFactoryWayland
[17580:17580:1118/172446:ERROR:gl_surface_egl.cc(259)] Trying to create surface without window.
[17580:17580:1118/172446:ERROR:gpu_command_buffer_stub.cc(447)] Failed to create surface.

[17492:17492:1118/172446:ERROR:command_buffer_proxy_impl.cc(164)] Failed to initialize command buffer service.
[17492:17492:1118/172446:FATAL:gpu_process_host_ui_shim.cc(204)] Check failed: false. Invalid message with type = 5439525
 [0x7f867154894e] base::debug::StackTrace::StackTrace()
 [0x7f8671588569] logging::LogMessage::~LogMessage()
 [0x7f8674bd05e9] content::GpuProcessHostUIShim::OnControlMessageReceived()
 [0x7f8674bcfae8] content::GpuProcessHostUIShim::OnMessageReceived()
 [0x7f8674bcf27f] content::RouteToGpuProcessHostUIShimTask()
 [0x7f8674bcc3da] base::internal::RunnableAdapter<>::Run()
 [0x7f8674bca83e] base::internal::InvokeHelper<>::MakeItSo()
 [0x7f8674bc8116] base::internal::Invoker<>::Run()
 [0x7f8670876470] base::Callback<>::Run()
 [0x7f867159262b] base::MessageLoop::RunTask()
 [0x7f8671592768] base::MessageLoop::DeferOrRunPendingTask()
 [0x7f8671592cb6] base::MessageLoop::DoWork()
 [0x7f8671534cba] base::MessagePumpLibevent::Run()
 [0x7f867159212a] base::MessageLoop::RunInternal()
 [0x7f8671591fce] base::MessageLoop::RunHandler()
 [0x7f86715c522e] base::RunLoop::Run()
 [0x7f8670ef2e23] ChromeBrowserMainParts::MainMessageLoopRun()
 [0x7f8674ad596a] content::BrowserMainLoop::RunMainMessageLoopParts()
 [0x7f8674adc02e] content::BrowserMainRunnerImpl::Run()
 [0x7f8674ad1a8f] content::BrowserMain()
 [0x7f867152a77a] content::RunNamedProcessTypeMain()
 [0x7f867152b88f] content::ContentMainRunnerImpl::Run()
 [0x7f8671529b0b] content::ContentMain()
 [0x7f8670712dfd] ChromeMain
 [0x7f8670712dc8] main
 [0x7f8668a95b45] <unknown>
 [0x7f8670712cb9] <unknown>

GDB backtrace:

#0  0x00007f8668aa99e9 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1  0x00007f8668aab0f8 in __GI_abort () at abort.c:90
#2  0x00007f8671547906 in base::debug::(anonymous namespace)::DebugBreak () at ../../base/debug/debugger_posix.cc:233
#3  0x00007f8671547912 in base::debug::BreakDebugger () at ../../base/debug/debugger_posix.cc:257
#4  0x00007f8671588835 in logging::LogMessage::~LogMessage (this=0x7fff52e626a0, __in_chrg=<optimized out>) at ../../base/logging.cc:666
#5  0x00007f8674bd05e9 in content::GpuProcessHostUIShim::OnControlMessageReceived (this=0x28a00e1f2020, message=...) at ../../content/browser/gpu/gpu_process_host_ui_shim.cc:204
#6  0x00007f8674bcfae8 in content::GpuProcessHostUIShim::OnMessageReceived (this=0x28a00e1f2020, message=...) at ../../content/browser/gpu/gpu_process_host_ui_shim.cc:158
#7  0x00007f8674bcf27f in content::RouteToGpuProcessHostUIShimTask (host_id=2, msg=...) at ../../content/browser/gpu/gpu_process_host_ui_shim.cc:94
#8  0x00007f8674bcc3da in base::internal::RunnableAdapter<void (*)(int, IPC::Message const&)>::Run (this=0x7fff52e62ab0, a1=@0x28a00e010198: 2, a2=...) at ../../base/bind_internal.h:228
#9  0x00007f8674bca83e in base::internal::InvokeHelper<false, void, base::internal::RunnableAdapter<void (*)(int, IPC::Message const&)>, void (int const&, IPC::Message const&)>::MakeItSo(base::internal::RunnableAdapter<void (*)(int, IPC::Message const&)>, int const&, IPC::Message const&) (runnable=..., a1=@0x28a00e010198: 2, a2=...)
    at ../../base/bind_internal.h:898
#10 0x00007f8674bc8116 in base::internal::Invoker<2, base::internal::BindState<base::internal::RunnableAdapter<void (*)(int, IPC::Message const&)>, void (int, IPC::Message const&), void (int, IPC::Message)>, void (int, IPC::Message const&)>::Run(base::internal::BindStateBase*) (base=0x28a00e010180) at ../../base/bind_internal.h:1253
#11 0x00007f8670876470 in base::Callback<void ()>::Run() const (this=0x7fff52e62e18) at ../../base/callback.h:396
#12 0x00007f867159262b in base::MessageLoop::RunTask (this=0x7f866fd19e20, pending_task=...) at ../../base/message_loop/message_loop.cc:491
#13 0x00007f8671592768 in base::MessageLoop::DeferOrRunPendingTask (this=0x7f866fd19e20, pending_task=...) at ../../base/message_loop/message_loop.cc:503
#14 0x00007f8671592cb6 in base::MessageLoop::DoWork (this=0x7f866fd19e20) at ../../base/message_loop/message_loop.cc:617
#15 0x00007f8671534cba in base::MessagePumpLibevent::Run (this=0x7f866fce1da0, delegate=0x7f866fd19e20) at ../../base/message_loop/message_pump_libevent.cc:232
#16 0x00007f867159212a in base::MessageLoop::RunInternal (this=0x7f866fd19e20) at ../../base/message_loop/message_loop.cc:441
#17 0x00007f8671591fce in base::MessageLoop::RunHandler (this=0x7f866fd19e20) at ../../base/message_loop/message_loop.cc:413
#18 0x00007f86715c522e in base::RunLoop::Run (this=0x7fff52e632d0) at ../../base/run_loop.cc:47
#19 0x00007f8670ef2e23 in ChromeBrowserMainParts::MainMessageLoopRun (this=0x7f866fce1c80, result_code=0x7f866fc4c678) at ../../chrome/browser/chrome_browser_main.cc:1627
#20 0x00007f8674ad596a in content::BrowserMainLoop::RunMainMessageLoopParts (this=0x7f866fc4c660) at ../../content/browser/browser_main_loop.cc:716
#21 0x00007f8674adc02e in content::BrowserMainRunnerImpl::Run (this=0x7f866fcfb7a0) at ../../content/browser/browser_main_runner.cc:121
#22 0x00007f8674ad1a8f in content::BrowserMain (parameters=...) at ../../content/browser/browser_main.cc:26
#23 0x00007f867152a77a in content::RunNamedProcessTypeMain (process_type="", main_function_params=..., delegate=0x7fff52e63df0) at ../../content/app/content_main_runner.cc:458
#24 0x00007f867152b88f in content::ContentMainRunnerImpl::Run (this=0x7f866fc53320) at ../../content/app/content_main_runner.cc:777
#25 0x00007f8671529b0b in content::ContentMain (argc=2, argv=0x7fff52e63f48, delegate=0x7fff52e63df0) at ../../content/app/content_main.cc:35
#26 0x00007f8670712dfd in ChromeMain (argc=2, argv=0x7fff52e63f48) at ../../chrome/app/chrome_main.cc:39
#27 0x00007f8670712dc8 in main (argc=2, argv=0x7fff52e63f48) at ../../chrome/app/chrome_exe_main_aura.cc:17

The GPU process backtrace:

#0  drm_intel_gem_bo_free (bo=bo@entry=0x24f315a08020) at intel_bufmgr_gem.c:921
#1  0x00007fbadd2b0c54 in drm_intel_gem_bo_alloc_internal (bufmgr=0x24f313a35020, name=0x7fbaddb78117 "region", size=0, flags=<optimized out>, tiling_mode=1, stride=0) at intel_bufmgr_gem.c:732
#2  0x00007fbaddadec06 in intel_region_alloc (screen=screen@entry=0x24f313e23b60, tiling=tiling@entry=1, cpp=4, width=width@entry=0, height=height@entry=0, expect_accelerated_upload=expect_accelerated_upload@entry=true) at intel_regions.c:145
#3  0x00007fbaddadfa3a in intel_create_image (screen=<optimized out>, width=0, height=0, format=<optimized out>, use=<optimized out>, loaderPrivate=<optimized out>) at intel_screen.c:500
#4  0x00007fbae88c5261 in get_back_bo (dri2_surf=dri2_surf@entry=0x24f3143d2520, buffer=buffer@entry=0x24f3143d25a0) at platform_wayland.c:284
#5  0x00007fbae88c530b in dri2_get_buffers_with_format (driDrawable=<optimized out>, width=0x24f3138bc828, height=0x24f3138bc82c, attachments=<optimized out>, count=<optimized out>, out_count=0x7fff242dc7ac, loaderPrivate=0x24f3143d2520) at platform_wayland.c:363
#6  0x00007fbaddad8ebd in intel_query_dri2_buffers (buffer_count=0x7fff242dc7ac, buffers=<synthetic pointer>, drawable=0x24f3138bc800, brw=0x24f31539d050) at intel_context.c:841
#7  intel_update_renderbuffers (context=context@entry=0x24f3138bcc60, drawable=drawable@entry=0x24f3138bc800) at intel_context.c:196
#8  0x00007fbaddad91c3 in intel_prepare_render (brw=brw@entry=0x24f31539d050) at intel_context.c:249
#9  0x00007fbaddaf7f9f in brw_try_draw_prims (max_index=4294967295, min_index=4294967295, ib=0x7fff242dc8d0, nr_prims=1, prim=0x7fff242dc8f0, arrays=0x24f313ff8518, ctx=0x24f31539d050) at brw_draw.c:382
#10 brw_draw_prims (ctx=0x24f31539d050, prim=0x7fff242dc8f0, nr_prims=1, ib=0x7fff242dc8d0, index_bounds_valid=<optimized out>, min_index=4294967295, max_index=4294967295, tfb_vertcount=0x0) at brw_draw.c:530
#11 0x00007fbadd61f2ca in vbo_handle_primitive_restart (ctx=ctx@entry=0x24f31539d050, prim=prim@entry=0x7fff242dc8f0, nr_prims=nr_prims@entry=1, ib=ib@entry=0x7fff242dc8d0, index_bounds_valid=index_bounds_valid@entry=0 '\000', min_index=min_index@entry=4294967295, max_index=max_index@entry=4294967295) at ../../../src/mesa/vbo/vbo_exec_array.c:585
#12 0x00007fbadd62026d in vbo_validated_drawrangeelements (ctx=ctx@entry=0x24f31539d050, mode=mode@entry=4, index_bounds_valid=index_bounds_valid@entry=0 '\000', start=start@entry=4294967295, end=end@entry=4294967295, count=count@entry=6, type=type@entry=5123, indices=indices@entry=0x0, basevertex=basevertex@entry=0, numInstances=numInstances@entry=1, 
    baseInstance=baseInstance@entry=0) at ../../../src/mesa/vbo/vbo_exec_array.c:1004
#13 0x00007fbadd620793 in vbo_exec_DrawElements (mode=4, count=6, type=5123, indices=0x0) at ../../../src/mesa/vbo/vbo_exec_array.c:1154
#14 0x00007fbaf6fbe673 in gfx::GLApiBase::glDrawElementsFn (this=0x24f314460430, mode=4, count=6, type=5123, indices=0x0) at gen/ui/gl/gl_bindings_autogen_gl.cc:3598
#15 0x00007fbaf6ef81d4 in gpu::gles2::GLES2DecoderImpl::DoDrawElements (this=0x24f31418da20, function_name=0x7fbaf9cc158f "glDrawElements", instanced=false, mode=4, count=6, type=5123, offset=0, primcount=0) at ../../gpu/command_buffer/service/gles2_cmd_decoder.cc:6353
#16 0x00007fbaf6ef8312 in gpu::gles2::GLES2DecoderImpl::HandleDrawElements (this=0x24f31418da20, immediate_data_size=0, c=...) at ../../gpu/command_buffer/service/gles2_cmd_decoder.cc:6386
#17 0x00007fbaf6eea387 in gpu::gles2::GLES2DecoderImpl::DoCommand (this=0x24f31418da20, command=304, arg_count=4, cmd_data=0x7fbadbf6b6ec) at ../../gpu/command_buffer/service/gles2_cmd_decoder.cc:3488
#18 0x00007fbaf6f7e67e in gpu::CommandParser::ProcessCommand (this=0x24f313cd99e0) at ../../gpu/command_buffer/service/cmd_parser.cc:67
#19 0x00007fbaf6f2170c in gpu::GpuScheduler::PutChanged (this=0x24f313c58380) at ../../gpu/command_buffer/service/gpu_scheduler.cc:79
#20 0x00007fbaf6ce5453 in content::GpuCommandBufferStub::PutChanged (this=0x24f3141dffe0) at ../../content/common/gpu/gpu_command_buffer_stub.cc:724
#21 0x00007fbaf6cec973 in base::internal::RunnableAdapter<void (content::GpuCommandBufferStub::*)()>::Run (this=0x7fff242dd700, object=0x24f3141dffe0) at ../../base/bind_internal.h:134
#22 0x00007fbaf6cec495 in base::internal::InvokeHelper<false, void, base::internal::RunnableAdapter<void (content::GpuCommandBufferStub::*)()>, void (content::GpuCommandBufferStub*)>::MakeItSo(base::internal::RunnableAdapter<void (content::GpuCommandBufferStub::*)()>, content::GpuCommandBufferStub*) (runnable=..., a1=0x24f3141dffe0)
    at ../../base/bind_internal.h:871
#23 0x00007fbaf6ceb978 in base::internal::Invoker<1, base::internal::BindState<base::internal::RunnableAdapter<void (content::GpuCommandBufferStub::*)()>, void (content::GpuCommandBufferStub*), void (base::internal::UnretainedWrapper<content::GpuCommandBufferStub>)>, void (content::GpuCommandBufferStub*)>::Run(base::internal::BindStateBase*) (
    base=0x24f313f62f20) at ../../base/bind_internal.h:1169
#24 0x00007fbaf1421470 in base::Callback<void ()>::Run() const (this=0x24f314336af8) at ../../base/callback.h:396
#25 0x00007fbaf6ecda4e in gpu::CommandBufferService::Flush (this=0x24f314336ab0, put_offset=21954) at ../../gpu/command_buffer/service/command_buffer_service.cc:92
#26 0x00007fbaf6ce4e23 in content::GpuCommandBufferStub::OnAsyncFlush (this=0x24f3141dffe0, put_offset=21954, flush_count=134) at ../../content/common/gpu/gpu_command_buffer_stub.cc:643
#27 0x00007fbaf6ce9aca in DispatchToMethod<content::GpuCommandBufferStub, void (content::GpuCommandBufferStub::*)(int, unsigned int), int, unsigned int> (obj=0x24f3141dffe0, method=(void (content::GpuCommandBufferStub::*)(content::GpuCommandBufferStub * const, int, unsigned int)) 0x7fbaf6ce4c18 <content::GpuCommandBufferStub::OnAsyncFlush(int, unsigned int)>, 
    arg=...) at ../../base/tuple.h:555
#28 0x00007fbaf6ce7d55 in GpuCommandBufferMsg_AsyncFlush::Dispatch<content::GpuCommandBufferStub, content::GpuCommandBufferStub, void (content::GpuCommandBufferStub::*)(int, unsigned int)> (msg=0x24f313c27380, obj=0x24f3141dffe0, sender=0x24f3141dffe0, func=
    (void (content::GpuCommandBufferStub::*)(content::GpuCommandBufferStub * const, int, unsigned int)) 0x7fbaf6ce4c18 <content::GpuCommandBufferStub::OnAsyncFlush(int, unsigned int)>) at ../../content/common/gpu/gpu_messages.h:531
#29 0x00007fbaf6ce0edc in content::GpuCommandBufferStub::OnMessageReceived (this=0x24f3141dffe0, message=...) at ../../content/common/gpu/gpu_command_buffer_stub.cc:200
#30 0x00007fbaf6cbff3e in content::MessageRouter::RouteMessage (this=0x24f314449440, msg=...) at ../../content/common/message_router.cc:49
#31 0x00007fbaf6cd118d in content::GpuChannel::HandleMessage (this=0x24f3144493a0) at ../../content/common/gpu/gpu_channel.cc:808
#32 0x00007fbaf6cdd31f in base::internal::RunnableAdapter<void (content::GpuChannel::*)()>::Run (this=0x7fff242de140, object=0x24f3144493a0) at ../../base/bind_internal.h:134
#33 0x00007fbaf6cdc0c8 in base::internal::InvokeHelper<true, void, base::internal::RunnableAdapter<void (content::GpuChannel::*)()>, void (base::WeakPtr<content::GpuChannel> const&)>::MakeItSo(base::internal::RunnableAdapter<void (content::GpuChannel::*)()>, base::WeakPtr<content::GpuChannel> const&) (runnable=..., weak_ptr=...)
    at ../../base/bind_internal.h:882
#34 0x00007fbaf6cda4b2 in base::internal::Invoker<1, base::internal::BindState<base::internal::RunnableAdapter<void (content::GpuChannel::*)()>, void (content::GpuChannel*), void (base::WeakPtr<content::GpuChannel>)>, void (content::GpuChannel*)>::Run(base::internal::BindStateBase*) (base=0x24f3157cf720) at ../../base/bind_internal.h:1169
#35 0x00007fbaf1421470 in base::Callback<void ()>::Run() const (this=0x7fff242de488) at ../../base/callback.h:396
#36 0x00007fbaf213d62b in base::MessageLoop::RunTask (this=0x7fff242debc0, pending_task=...) at ../../base/message_loop/message_loop.cc:491
#37 0x00007fbaf213d768 in base::MessageLoop::DeferOrRunPendingTask (this=0x7fff242debc0, pending_task=...) at ../../base/message_loop/message_loop.cc:503
#38 0x00007fbaf213dcb6 in base::MessageLoop::DoWork (this=0x7fff242debc0) at ../../base/message_loop/message_loop.cc:617
#39 0x00007fbaf2145db9 in base::MessagePumpDefault::Run (this=0x7fbaf089f890, delegate=0x7fff242debc0) at ../../base/message_loop/message_pump_default.cc:32
#40 0x00007fbaf213d12a in base::MessageLoop::RunInternal (this=0x7fff242debc0) at ../../base/message_loop/message_loop.cc:441
#41 0x00007fbaf213cfce in base::MessageLoop::RunHandler (this=0x7fff242debc0) at ../../base/message_loop/message_loop.cc:413
#42 0x00007fbaf217022e in base::RunLoop::Run (this=0x7fff242de8e0) at ../../base/run_loop.cc:47
#43 0x00007fbaf213c8de in base::MessageLoop::Run (this=0x7fff242debc0) at ../../base/message_loop/message_loop.cc:311
#44 0x00007fbaf6b35726 in content::GpuMain (parameters=...) at ../../content/gpu/gpu_main.cc:305
#45 0x00007fbaf20d577a in content::RunNamedProcessTypeMain (process_type="gpu-process", main_function_params=..., delegate=0x7fff242dfc20) at ../../content/app/content_main_runner.cc:458
#46 0x00007fbaf20d688f in content::ContentMainRunnerImpl::Run (this=0x7fbaf07fe320) at ../../content/app/content_main_runner.cc:777
#47 0x00007fbaf20d4b0b in content::ContentMain (argc=11, argv=0x7fff242dfd78, delegate=0x7fff242dfc20) at ../../content/app/content_main.cc:35
#48 0x00007fbaf12bddfd in ChromeMain (argc=11, argv=0x7fff242dfd78) at ../../chrome/app/chrome_main.cc:39
#49 0x00007fbaf12bddc8 in main (argc=11, argv=0x7fff242dfd78) at ../../chrome/app/chrome_exe_main_aura.cc:17

@etrunko
Copy link
Contributor Author

etrunko commented Nov 18, 2013

Any help debugging this one is highly appreciated

@kalyankondapally
Copy link
Contributor

How are you testing this ?

@etrunko
Copy link
Contributor Author

etrunko commented Nov 18, 2013

Just launch chrome and press F11

@kalyankondapally
Copy link
Contributor

hmm, I dont see the crash. I can see that titlebar/decorators are hidden(even though window doesn't get resized as it should be).

Additional changes(compared to master), I have is the multi window support which also fixed some basic issues. Changes can be seen here: https://github.com/kalyankondapally/ozone-wayland/commits/MultiWindow

You might want to test again after integrating the changes ?

@etrunko
Copy link
Contributor Author

etrunko commented Nov 18, 2013

Yes, it is expected that the contents don't resize. It is to be done in a next patch. I just realized you have pushed a new hash for chromium, I will try with the rebased version and check back if it is still crashing.

@kalyankondapally
Copy link
Contributor

Ya, I don't expect the resizing to work till 112 is fixed, which I will deal with after Offscreen rendering support. I am happy with the current state, if we can ensure that the crash thing is resolved.

@kalyankondapally
Copy link
Contributor

K, issue was more of a merge conflict. With that fixed seems to work now. This is how it's working:

  1. Launch chrome
  2. press F11

You can see that shell surface is resized to same dimensions as Weston. The screen is completely black, which issue 112 is supposed to fix.

@etrunko
Copy link
Contributor Author

etrunko commented Nov 19, 2013

I updated my source but I am still unable to test it locally, every time I try to run chrome it aborts with the following message:

out/Debug/chrome --no-sandbox: ../../base/memory/ref_counted.h:260: T* scoped_refptr<T>::operator->() const [with T = gfx::PlatformFont]: Assertion `ptr_ != __null' failed.
Aborted (core dumped)

@kalyankondapally
Copy link
Contributor

@etrunko This is nothing to do with your changes. I apologise for the hassle you had with latest sources and I couldn't respond in time. I updated the master branch with right hash now.

@etrunko
Copy link
Contributor Author

etrunko commented Nov 21, 2013

I noticed this message the other day, while testing this code. Does it affect us?

[9401:9401:1121/164227:ERROR:fullscreen_aura.cc(15)] Not implemented reached in bool IsFullScreenMode()

Looking at the code, there is only a big TODO comment about the way it should be implemented.

@kalyankondapally
Copy link
Contributor

I don't think it's that important to block this task.

@etrunko
Copy link
Contributor Author

etrunko commented Nov 22, 2013

Ok, rebased with latest master. PTAL etrunko/ozone-wayland@d53d2e4

@kalyankondapally
Copy link
Contributor

Done: 1ee5ade
bf1dc26

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants