-
Notifications
You must be signed in to change notification settings - Fork 78
Fullscreen support #128
Comments
Note that #112 needs to be fixed first before starting on this work. I will be coming to that soon as it needs to be handled with offscreen support. |
Here is what it should look like: etrunko/ozone-wayland@e47c306 Implement Fullscreen mode This is causing the program to abort for some reason. The log is the following:
GDB backtrace:
The GPU process backtrace:
|
Any help debugging this one is highly appreciated |
How are you testing this ? |
Just launch chrome and press F11 |
hmm, I dont see the crash. I can see that titlebar/decorators are hidden(even though window doesn't get resized as it should be). Additional changes(compared to master), I have is the multi window support which also fixed some basic issues. Changes can be seen here: https://github.com/kalyankondapally/ozone-wayland/commits/MultiWindow You might want to test again after integrating the changes ? |
Yes, it is expected that the contents don't resize. It is to be done in a next patch. I just realized you have pushed a new hash for chromium, I will try with the rebased version and check back if it is still crashing. |
Ya, I don't expect the resizing to work till 112 is fixed, which I will deal with after Offscreen rendering support. I am happy with the current state, if we can ensure that the crash thing is resolved. |
K, issue was more of a merge conflict. With that fixed seems to work now. This is how it's working:
You can see that shell surface is resized to same dimensions as Weston. The screen is completely black, which issue 112 is supposed to fix. |
I updated my source but I am still unable to test it locally, every time I try to run chrome it aborts with the following message:
|
@etrunko This is nothing to do with your changes. I apologise for the hassle you had with latest sources and I couldn't respond in time. I updated the master branch with right hash now. |
I noticed this message the other day, while testing this code. Does it affect us? [9401:9401:1121/164227:ERROR:fullscreen_aura.cc(15)] Not implemented reached in bool IsFullScreenMode() Looking at the code, there is only a big TODO comment about the way it should be implemented. |
I don't think it's that important to block this task. |
Ok, rebased with latest master. PTAL etrunko/ozone-wayland@d53d2e4 |
Add support for toggling windows fullscreen.
Dependency: #112.
Blocks: #4 .
Sub-Tasks: None.
The text was updated successfully, but these errors were encountered: