Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake config needs fixing #289

Closed
fschlimb opened this issue Aug 11, 2022 · 1 comment
Closed

cmake config needs fixing #289

fschlimb opened this issue Aug 11, 2022 · 1 comment
Assignees
@diptorupd

Comments

@fschlimb
Copy link
Contributor

fschlimb commented Aug 11, 2022 •
edited
Loading

Currently, on refactor, the following things don't work correctly with cmake:

  • lib/cmake/imex/IMEXTargets.cmake is not being installed
    • Ideally we'd do this with LLVM's machinery, but that requires more than just set_property(GLOBAL PROPERTY IMEX_HAS_EXPORTS TRUE).
  • include headers are nested in a double 'include' dir (e.g. imex/include/include/imex/...)
@fschlimb fschlimb changed the title IMEXTargets.cmake needs install cmake config needs fixing Aug 11, 2022
@fschlimb fschlimb mentioned this issue Aug 15, 2022
Closed
6 tasks
@fschlimb fschlimb mentioned this issue Oct 27, 2022
Merged
6 tasks
@fschlimb
Copy link
Contributor Author

fschlimb commented Dec 7, 2022

Fixed by #290

@fschlimb fschlimb closed this as completed Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diptorupd diptorupd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fschlimb @diptorupd