Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chatglm2 multi-turn streamchat #8867

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Fix chatglm2 multi-turn streamchat #8867

merged 1 commit into from
Sep 1, 2023

Conversation

yangw1234
Copy link
Contributor

@yangw1234 yangw1234 commented Aug 31, 2023 •
edited
Loading

Description

Fix chatglm2 multi-turn streamchat: revert the output kv_cache to its original format.

fix #8859

@yangw1234 yangw1234 requested a review from MeouSker77 August 31, 2023 18:15
MeouSker77
MeouSker77 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@MeouSker77 MeouSker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangw1234 yangw1234 merged commit 2d5bbde into intel:main Sep 1, 2023
@yangw1234 yangw1234 mentioned this pull request Sep 1, 2023
Open
liu-shaojun pushed a commit that referenced this pull request Mar 25, 2024
@yangw1234
Fix chatglm2 multi-turn streamchat (#8867)
242c9d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MeouSker77 MeouSker77 MeouSker77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-round conversation failure when enabled 'return_past_key_values'
2 participants
@yangw1234 @MeouSker77