Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python ChannelNormalize have different parameter order with scala ChannelNormalize #2544

Closed
jenniew opened this issue May 25, 2018 · 3 comments · Fixed by #2549
Closed

Python ChannelNormalize have different parameter order with scala ChannelNormalize #2544

jenniew opened this issue May 25, 2018 · 3 comments · Fixed by #2549

Comments

@jenniew
Copy link
Contributor

jenniew commented May 25, 2018

Python ChannelNormalize initializer:
def init(self, mean_r, mean_b, mean_g, std_r=1.0, std_g=1.0, std_b=1.0, bigdl_type="float"):
super(ChannelNormalize, self).init(bigdl_type, mean_r, mean_g, mean_b, std_r, std_g, std_b)
The order is: mean_r, mean_b, mean_g, std_r, std_g, std_b
Scala ChannelNormalize initializer:
def apply(meanR: Float, meanG: Float, meanB: Float,
stdR: Float = 1, stdG: Float = 1, stdB: Float = 1)
The order is: meanR, meanG, meanB, stdR, stdG, stdB

@yiheng
Copy link
Contributor

yiheng commented May 26, 2018

Do you mean we invoke the python ChannelNormalize incorrectly in the example?

@jenniew
Copy link
Contributor Author

jenniew commented May 27, 2018

Yes

@wzhongyuan
Copy link
Contributor

@jenniew

yes, the order is different.... not sure why it's done like this...

I will run another with this fixed to see if we have a better result once there is available cluster resource

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants