From 54b1d48e860e0265b4d48fa808c0ca42f3527b27 Mon Sep 17 00:00:00 2001 From: Yonatan Goldschmidt Date: Wed, 22 Nov 2023 21:50:42 +0200 Subject: [PATCH] build: node: Pin node-gyp==^9.4.1 node-gyp 10.x.x was released recently, and our build started failing with this error: 16.93 gyp ERR! configure error 16.93 gyp ERR! stack TypeError: Cannot read property 'pipeline' of undefined Pinning to 9.x.x helps. --- scripts/build_node_package.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/build_node_package.sh b/scripts/build_node_package.sh index af66a2aca..4722a9493 100755 --- a/scripts/build_node_package.sh +++ b/scripts/build_node_package.sh @@ -10,7 +10,7 @@ git clone https://github.com/mmarchini-oss/node-linux-perf.git $MODULE_PATH cd $MODULE_PATH git reset --hard $GIT_REV -npm install -g node-gyp +npm install -g node-gyp@^9.4.1 # pinned, as 10.x.x was broken, see my commit message curl -L https://github.com/nodejs/nan/archive/refs/tags/v2.16.0.tar.gz -o nan.tar.gz tar -vxzf nan.tar.gz -C /tmp NAN_PATH=$(realpath /tmp/nan-*)