Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings with GCC 12.2.1 #47

Open
bkmgit opened this issue Nov 9, 2022 · 8 comments
Open

Warnings with GCC 12.2.1 #47

bkmgit opened this issue Nov 9, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@bkmgit
Copy link

bkmgit commented Nov 9, 2022

When building with GCC 12.2.1 get the following warnings:

In file included from /home/user/ipp-crypto-ippcp_2021.6/build/c_sources/n0/c_intel64/n0_pcpaes_cmacgettag.c:32:
In function ‘PadBlock’,
    inlined from ‘n0_ippsAES_CMACGetTag’ at /home/user/ipp-crypto-ippcp_2021.6/build/c_sources/n0/c_intel64/n0_pcpaes_cmacgettag.c:82:10:
/home/user/ipp-crypto-ippcp_2021.6/sources/ippcp/pcptool.h:94:12: error: writing 16 bytes into a region of size 0 [-Werror=stringop-overflow=]       
   94 |       d[k] = paddingByte;
      |       ~~~~~^~~~~~~~~~~~~
/home/user/ipp-crypto-ippcp_2021.6/build/c_sources/n0/c_intel64/n0_pcpaes_cmacgettag.c: In function ‘n0_ippsAES_CMACGetTag’:
/home/user/ipp-crypto-ippcp_2021.6/build/c_sources/n0/c_intel64/n0_pcpaes_cmacgettag.c:71:13: note: at offset 16 into destination object ‘locBuffer’ of size 16
   71 |       Ipp8u locBuffer[MBS_RIJ128];
      |             ^~~~~~~~~
In function ‘PadBlock’,
    inlined from ‘n0_ippsAES_CMACGetTag’ at /home/user/ipp-crypto-ippcp_2021.6/build/c_sources/n0/c_intel64/n0_pcpaes_cmacgettag.c:82:10:
/home/user/ipp-crypto-ippcp_2021.6/sources/ippcp/pcptool.h:94:12: error: writing 16 bytes into a region of size 0 [-Werror=stringop-overflow=]
   94 |       d[k] = paddingByte;
      |       ~~~~~^~~~~~~~~~~~~
/home/user/ipp-crypto-ippcp_2021.6/build/c_sources/n0/c_intel64/n0_pcpaes_cmacgettag.c: In function ‘n0_ippsAES_CMACGetTag’:
/home/user/ipp-crypto-ippcp_2021.6/build/c_sources/n0/c_intel64/n0_pcpaes_cmacgettag.c:71:13: note: at offset [32, 48] into destination object ‘locBuffer’ of size 16 
   71 |       Ipp8u locBuffer[MBS_RIJ128];
      |             ^~~~~~~~~ 
cc1: all warnings being treated as errors
make[2]: *** [sources/ippcp/CMakeFiles/ippcp_s_n0.dir/build.make:1602: sources/ippcp/CMakeFiles/ippcp_s_n0.dir/__/__/c_sources/n0/c_intel64/n0_pcpaes_cmacgettag.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:426: sources/ippcp/CMakeFiles/ippcp_s_n0.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
@bkmgit
Copy link
Author

bkmgit commented Nov 9, 2022

This is with release 2021.6

@ElenaTyuleneva
Copy link
Contributor

Hi @bkmgit , IPP Crypto doesn't support the build with gcc12 now. Please, refer to software requirements.

@bkmgit
Copy link
Author

bkmgit commented Nov 27, 2022

Hi @ElenaTyuleneva Thanks for feedback. Got it to build with Clang 14.0.5 Would pull requests:
a) to use GitHub actions CI to do test builds be considered?
b) to fixe the above warnings with GCC 12 be considered?

@bkmgit
Copy link
Author

bkmgit commented Nov 27, 2022

There seems to have been a related issue #16 my builds have been on Fedora 36

@andreyfe1
Copy link

Hi @bkmgit. Sorry for delay...
a) It's a great idea. Currently we don't have GitHub actions CI, but we can prioritize.
b) We are planning to add GCC12 in one of the next releases. Any pull requests are welcome!

@paveldyakov
Copy link

Hi @bkmgit,

Could you please try to build again with GCC 12.2? N0 build was disabled in IPP Crypto in the latest releases.
Now I see no issue with GCC 12.2

@bkmgit
Copy link
Author

bkmgit commented Jan 17, 2024

Thanks. Will check this, hopefully will also work with GCC 13.

@paveldyakov
Copy link

Hi @bkmgit,
Please let me know if we can close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants