Data source github_team retrieves 30 members max

[adebasi]

Terraform Version

v0.14.6

Affected Resource(s)

Data source:

• github_team

Terraform Configuration Files

# Simple config to reproduce issue

terraform {
  required_providers {
    github = {
      source = "integrations/github"
      version = "4.4.0"
    }
  }
}

provider "github" {
  owner = "<owner>"
  token = "<token>"
}

data "github_team" "my-team" {
  slug = "<team-with-more-than-30-members>"
}

# Dummy resource to use the members
resource "github_team" "new_team" {
  for_each = toset(data.github_team.my-team.members)
  name        = "foobar-${each.value}"
  description = "Some cool team"
  privacy     = "closed"
}

Expected Behavior

Get all GitHub team members

Actual Behavior

I get a maximum of 30 team members

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

1. terraform init
2. terraform plan
3. You can see that only 30 resources would get created

References

• This is the call to retrieve the list of team members https://github.com/integrations/terraform-provider-github/blob/master/github/data_source_github_team.go#L62
• The GitHub API allows following request parameters page and per_page - 30 seems to be the default per page: https://docs.github.com/en/rest/reference/teams#list-team-members

[majormoses]

Bumping up the number is fine but we need to also pagination (can be separate pull request). I am not using this pattern but I have teams with well over 100 members.

[adebasi]

@majormoses, I agree. I adapted to PR to use pagination. Please have another look