Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve repository name to node ID if provided to github_branch_protection #593

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

jcudit
Copy link
Contributor

@jcudit jcudit commented Nov 6, 2020

This allows uses of the github_branch_protection resource to pass in the repository name instead of its node_id. A convenience requested while mopping up changes between the previous and new implementations.

/cc https://github.com/terraform-providers/terraform-provider-github/issues/566#issuecomment-713709445
/cc https://github.com/terraform-providers/terraform-provider-github/pull/592#discussion_r518754671
/cc @onwsk8r

@ghost ghost added size/M Type: Documentation Improvements or additions to documentation labels Nov 6, 2020
@jcudit jcudit marked this pull request as ready for review November 6, 2020 19:29
@jcudit jcudit merged commit 0fd055c into master Nov 9, 2020
@jcudit jcudit deleted the bp-repo-id branch November 9, 2020 13:19
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant